New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZB exchange scraper #48

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@montanaflynn
Contributor

montanaflynn commented Sep 17, 2018

Adds 206 coin pairs to the exchange scraper from the ZB exchange using their websocket API.

Because they use a weird format for the pairs without a delimiter I had to first manually add an underscore and then remove _trades which is needed for their websocket API. To assist with adding the 206 coin pairs to exchange-scrapers/config/exchange-scrapers.json I wrote a small program:

https://gist.github.com/montanaflynn/41d8ef164bc897bab7e53ddf9a12bbb1

@gitcoinbot gitcoinbot referenced this pull request Sep 17, 2018

Closed

www.zb.com api scrapping #46

@frranck

This comment has been minimized.

Contributor

frranck commented Sep 18, 2018

hi @montanaflynn
are you negating the price on sells ? We want the volume to be negative on sells.


> 
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.35 0.0017 2018-09-18 09:13:28 +0200 CEST 196206758 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.33 0.0005 2018-09-18 09:13:28 +0200 CEST 196206759 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.35 0.0022 2018-09-18 09:13:28 +0200 CEST 196206760 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.27 0.001 2018-09-18 09:13:28 +0200 CEST 196206761 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.28 0.0004 2018-09-18 09:13:28 +0200 CEST 196206762 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.26 0.002 2018-09-18 09:13:28 +0200 CEST 196206763 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.3 0.0004 2018-09-18 09:13:28 +0200 CEST 196206764 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.27 0.0018 2018-09-18 09:13:28 +0200 CEST 196206765 ZB}
> 2018/09/18 09:13:29 Trade: &{BTC btcusdt -6281.26 0.0017 2018-09-18 09:13:28 +0200 CEST 196206766 ZB}
> 

@montanaflynn

This comment has been minimized.

Contributor

montanaflynn commented Sep 18, 2018

Hey @frranck, yeah I accidentally negated price instead of volume, fixed now!

@frranck frranck merged commit 30a4ec0 into diadata-org:master Sep 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment