Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radius is wrong #35

Closed
byorgey opened this issue Mar 6, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@byorgey
Copy link
Member

commented Mar 6, 2013

>>> radius unitX (circle 1 :: D R2)
1.1102230246251565e-16

wat.

@byorgey byorgey referenced this issue Mar 6, 2013

Closed

radius is wrong #75

@byorgey byorgey closed this in f3a216e Mar 6, 2013

byorgey pushed a commit that referenced this issue Mar 6, 2013

Brent Yorgey
bug fix: compute diameter correctly: add scalars instead of subtracting
Fixes #35. This one was sneaky.  The bug was introduced in
0681b24,
which looks innocuous on the surface -- but there's a big difference
between subtracting two *vectors* (what the original code did) and
subtracting two *scalars* (which is what the code does now).  What we
actually want to do is *add* the two scalars.
@mgsloan

This comment has been minimized.

Copy link
Member

commented Mar 6, 2013

Oh man, my bad!

@byorgey

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2013

No worries! Anyone could make a simple (and subtle) mistake like that. If anything I'm just as much to blame for not reviewing more carefully! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.