Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add b->a instance for Juxtaposable #45

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
2 participants
@cscheid
Copy link
Contributor

cscheid commented Oct 23, 2013

No description provided.

Carlos Scheidegger

byorgey added a commit that referenced this pull request Oct 23, 2013

Merge pull request #45 from cscheid/Juxtaposable-b-to-a-instance
add b->a instance for Juxtaposable

@byorgey byorgey merged commit 656af78 into diagrams:master Oct 23, 2013

1 check passed

default The Travis CI build passed
Details
@byorgey

This comment has been minimized.

Copy link
Member

byorgey commented Oct 23, 2013

Thanks! And what about the Alignable instance?

@cscheid

This comment has been minimized.

Copy link
Contributor Author

cscheid commented Oct 23, 2013

This is where I confess I didn't actually try to compile or run the code above. The instance was obvious enough that I felt safe.

Alignable instances, on the other hand, all seemed to define something else than alignBy, so I wanted to make sure it compiled. Which led me to one hour of wrestling with cabal and hsenv, on which I'm still working.

Also, these are not for the lens branches. I assume you'd like these instances there as well?

@byorgey

This comment has been minimized.

Copy link
Member

byorgey commented Oct 23, 2013

Hehe, no worries. The Travis builds help there -- at least it will ensure that it compiles. If you submit a pull request I can take a careful look at the Alignable instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.