New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projections rebase #50

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@bergey
Member

bergey commented Jan 24, 2014

This is a proposal for non-affine transformations, which I've provisionally called Projections. Before this is ready to merge, we should choose a better name for applying a Projection. The obvious choice project conflicts with Data.VectorSpace.project.

I'll add some examples on the PR for diagrams-lib.

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Feb 9, 2014

Member

What's the rationale for this going in diagrams-core (as opposed to -lib)?

Member

byorgey commented Feb 9, 2014

What's the rationale for this going in diagrams-core (as opposed to -lib)?

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Feb 9, 2014

Member

I put it here for consistency with Transformable. Now that you ask, I see that Transformable is in -core in part because there are several instances in -core, which isn't true of Deformable. Shall I move it over to -lib?

Member

bergey commented Feb 9, 2014

I put it here for consistency with Transformable. Now that you ask, I see that Transformable is in -core in part because there are several instances in -core, which isn't true of Deformable. Shall I move it over to -lib?

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Feb 9, 2014

Member

Well, not only are there instances for Transformable in -core, the definition of QDiagram itself involves Transformations. So the transformation stuff really is an integral part of the core library. The boundary between -core and -lib is always a bit blurry, but my general approach has usually been to prefer putting things in -lib when possible, so I think the deform stuff would probably fit better in -lib.

However, we still might want to put, e.g. a note or two in the Haddocks for transformations pointing to the deformation stuff in -lib, so if people are looking at transformations and wondering why only affine are supported they will find a pointer to -lib.

Member

byorgey commented Feb 9, 2014

Well, not only are there instances for Transformable in -core, the definition of QDiagram itself involves Transformations. So the transformation stuff really is an integral part of the core library. The boundary between -core and -lib is always a bit blurry, but my general approach has usually been to prefer putting things in -lib when possible, so I think the deform stuff would probably fit better in -lib.

However, we still might want to put, e.g. a note or two in the Haddocks for transformations pointing to the deformation stuff in -lib, so if people are looking at transformations and wondering why only affine are supported they will find a pointer to -lib.

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Feb 9, 2014

Member

I've moved all the code to -lib. We can add the Haddocks later, without all the mess in this branch.

Member

bergey commented Feb 9, 2014

I've moved all the code to -lib. We can add the Haddocks later, without all the mess in this branch.

@bergey bergey closed this Feb 9, 2014

@bergey bergey deleted the projections-rebase branch Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment