New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wrapped instances for lens-4.0 #51

Merged
merged 6 commits into from Feb 8, 2014

Conversation

Projects
None yet
3 participants
@bergey
Member

bergey commented Jan 29, 2014

Do not merge until the rest of diagrams is similarly updated. Opening the PR to make sure anyone else inclined to build against lens-4.0 finds it.

lens-4.0 changes the interface for Wrapped, including reversing the order of type parameters. All instances and uses need to be changed.

The commit below is sufficient to build -core.

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Jan 30, 2014

Member

Incidentally, our Travis builds with GHC HEAD are hanging up on MonadCatchIO-transformers-0.3.0.0, which is deprecated package and a dependency of lens-3.10 replaced in 4.0. (I believe lens 4 is out this week because we're expecting a GHC 7.8 RC.)

Member

bergey commented Jan 30, 2014

Incidentally, our Travis builds with GHC HEAD are hanging up on MonadCatchIO-transformers-0.3.0.0, which is deprecated package and a dependency of lens-3.10 replaced in 4.0. (I believe lens 4 is out this week because we're expecting a GHC 7.8 RC.)

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Jan 30, 2014

Member

Oh, excellent. I may put a bit of time this afternoon into seeing if I can get our travis builds working smoothly again.

Member

byorgey commented Jan 30, 2014

Oh, excellent. I may put a bit of time this afternoon into seeing if I can get our travis builds working smoothly again.

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Jan 30, 2014

Member

I was just looking at that, and had one thought, which I just pushed. Have to run now, though, and I probably won't have more time until tomorrow.

Member

bergey commented Jan 30, 2014

I was just looking at that, and had one thought, which I just pushed. Have to run now, though, and I probably won't have more time until tomorrow.

@ekmett

This comment has been minimized.

Show comment
Hide comment
@ekmett

ekmett Jan 30, 2014

You'll also need Rewrapped as well as Wrapped now.

By splitting them we were able to greatly improve type inference.

The direction change came from making them compliant with the prism argument order, as evidenced by the current _Wrapped naming convention mirroring the prisms for constructors.

ekmett commented Jan 30, 2014

You'll also need Rewrapped as well as Wrapped now.

By splitting them we were able to greatly improve type inference.

The direction change came from making them compliant with the prism argument order, as evidenced by the current _Wrapped naming convention mirroring the prisms for constructors.

@bergey bergey referenced this pull request Feb 6, 2014

Merged

Lens4 #154

byorgey added a commit that referenced this pull request Feb 8, 2014

Merge pull request #51 from diagrams/lens4
Update Wrapped instances for lens-4.0

@byorgey byorgey merged commit 2bd64ae into master Feb 8, 2014

@byorgey byorgey deleted the lens4 branch Feb 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment