New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks #57

Merged
merged 3 commits into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
@tdox
Contributor

tdox commented Mar 5, 2014

Other required change is in diagrams-svg, branch hyperlinks. Discussion is here:
https://groups.google.com/forum/#!topic/diagrams-discuss/YBiZmSCBQLU

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Mar 5, 2014

Member

This looks good, thanks! It occurs to me that Annotation is a bad name since we're already using UpAnnots and DownAnnots, but that's not your fault. In a way, Annotation is the right name and we should come up with better names for the other two.

Member

byorgey commented Mar 5, 2014

This looks good, thanks! It occurs to me that Annotation is a bad name since we're already using UpAnnots and DownAnnots, but that's not your fault. In a way, Annotation is the right name and we should come up with better names for the other two.

@tdox

This comment has been minimized.

Show comment
Hide comment
@tdox

tdox Mar 5, 2014

Contributor

Yes, I was confused at first about what you meant by Annotation, because at first I saw only the UpAnnots and DownAnnots decribed in the docs. However, elsewhere in the code (I forget where) you call the 'a' an annotation.

Contributor

tdox commented Mar 5, 2014

Yes, I was confused at first about what you meant by Annotation, because at first I saw only the UpAnnots and DownAnnots decribed in the docs. However, elsewhere in the code (I forget where) you call the 'a' an annotation.

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Mar 5, 2014

Member

Right, in the dual-tree documentation I think we call a an annotation.

Member

byorgey commented Mar 5, 2014

Right, in the dual-tree documentation I think we call a an annotation.

byorgey added a commit that referenced this pull request Mar 5, 2014

@byorgey byorgey merged commit 6a1d4e1 into diagrams:master Mar 5, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment