New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stuff #72

Merged
merged 20 commits into from Oct 28, 2014

Conversation

Projects
None yet
3 participants
@cchalmers
Member

cchalmers commented Oct 12, 2014

Not ready to merge.

New Measure

The new measure is now a specialised Reader. Since a Data instance couldn't be derived I've had to change how measures are implemented:

  • New MAttribute that holds Measured things. The Transformable instance scales the local parts.
  • When compiling, these MAttributes are turned into normal Atributes using the global and normalised scales.
  • Backends no longer have to extract output measures (so they all need changing).
  • No more Data instances needed for n.

Other changes

  • New OpacityGroup annotation, backends can implement similar to -svg's Href.
  • Style now uses HashMap which should be faster and doesn't rely TypeRef's non-unique show instance.
@jeffreyrosenbluth

This comment has been minimized.

Show comment
Hide comment
@jeffreyrosenbluth

jeffreyrosenbluth Oct 12, 2014

Member

Do all of the backends need changes?

Member

jeffreyrosenbluth commented Oct 12, 2014

Do all of the backends need changes?

@cchalmers

This comment has been minimized.

Show comment
Hide comment
@cchalmers

cchalmers Oct 12, 2014

Member

Small ones. They'll need to remove any fromMeasures and SizeSpec might be slightly different.

They won't need to implement from OpacityGroup but I think most backends could support it.

Member

cchalmers commented Oct 12, 2014

Small ones. They'll need to remove any fromMeasures and SizeSpec might be slightly different.

They won't need to implement from OpacityGroup but I think most backends could support it.

@jeffreyrosenbluth

This comment has been minimized.

Show comment
Hide comment
@jeffreyrosenbluth

jeffreyrosenbluth Oct 12, 2014

Member

OK, It might be a good idea to mention this in the PR,
since merging it will break other packages.

On Sun, Oct 12, 2014 at 12:07 PM, Chris notifications@github.com wrote:

Small ones. They'll need to remove any fromMeasures and SizeSpec might be
slightly different.

They won't need to implement from OpacityGroup but I think most backends
could support it.


Reply to this email directly or view it on GitHub
#72 (comment).

Member

jeffreyrosenbluth commented Oct 12, 2014

OK, It might be a good idea to mention this in the PR,
since merging it will break other packages.

On Sun, Oct 12, 2014 at 12:07 PM, Chris notifications@github.com wrote:

Small ones. They'll need to remove any fromMeasures and SizeSpec might be
slightly different.

They won't need to implement from OpacityGroup but I think most backends
could support it.


Reply to this email directly or view it on GitHub
#72 (comment).

@jeffreyrosenbluth

This comment has been minimized.

Show comment
Hide comment
@jeffreyrosenbluth

jeffreyrosenbluth Oct 15, 2014

Member

Looking good!

Member

jeffreyrosenbluth commented on 2ba29ee Oct 15, 2014

Looking good!

jeffreyrosenbluth added a commit that referenced this pull request Oct 28, 2014

@jeffreyrosenbluth jeffreyrosenbluth merged commit 7fde439 into master Oct 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jeffreyrosenbluth jeffreyrosenbluth deleted the new-stuff branch Oct 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment