New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for GHC-7.10, -Wall #81

Merged
merged 4 commits into from Mar 10, 2015

Conversation

Projects
None yet
3 participants
@bergey
Member

bergey commented Feb 27, 2015

Most of Foldable & Traversable are now in Prelude, so importing these
libraries is redundant. I've just disabled those warnings.

update for GHC-7.10, -Wall
Most of Foldable & Traversable are now in Prelude, so importing these
libraries is redundant.  I've just disabled those warnings.
Show outdated Hide outdated src/Diagrams/Core/Names.hs Outdated
Show outdated Hide outdated src/Diagrams/Core/Names.hs Outdated
@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Mar 1, 2015

Member

I spoke too soon about merging this. In Names.hs, I was tripped up by the fact that overlapping instances compile fine, and errors only appear where they are used. Now diagrams-contrib fails to build: https://travis-ci.org/diagrams/diagrams-contrib/jobs/52657142

I think the overlapping instances are

instance IsName Char
instance IsName String
instance IsName a => IsName [a]

Can we just drop the String instance? If not, I'll fix it up with CPP.

Member

bergey commented Mar 1, 2015

I spoke too soon about merging this. In Names.hs, I was tripped up by the fact that overlapping instances compile fine, and errors only appear where they are used. Now diagrams-contrib fails to build: https://travis-ci.org/diagrams/diagrams-contrib/jobs/52657142

I think the overlapping instances are

instance IsName Char
instance IsName String
instance IsName a => IsName [a]

Can we just drop the String instance? If not, I'll fix it up with CPP.

@cchalmers

This comment has been minimized.

Show comment
Hide comment
@cchalmers

cchalmers Mar 1, 2015

Member

Yeah, just remove the String instance. Seems like it was a mistake to be there in the first place.

Member

cchalmers commented Mar 1, 2015

Yeah, just remove the String instance. Seems like it was a mistake to be there in the first place.

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Mar 2, 2015

Member

Indeed, I don't know of any good reason to have a separate (overlapping)
String instance.

On Sun, Mar 1, 2015 at 3:42 PM, Chris notifications@github.com wrote:

Yeah, just remove the String instance. Seems like it was a mistake to be
there in the first place.


Reply to this email directly or view it on GitHub
#81 (comment).

Member

byorgey commented Mar 2, 2015

Indeed, I don't know of any good reason to have a separate (overlapping)
String instance.

On Sun, Mar 1, 2015 at 3:42 PM, Chris notifications@github.com wrote:

Yeah, just remove the String instance. Seems like it was a mistake to be
there in the first place.


Reply to this email directly or view it on GitHub
#81 (comment).

cchalmers added a commit that referenced this pull request Mar 10, 2015

Merge pull request #81 from diagrams/ghc-710
update for GHC-7.10, -Wall

@cchalmers cchalmers merged commit 33ca362 into master Mar 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cchalmers cchalmers deleted the ghc-710 branch Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment