Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre 1.3 #82

Merged
merged 8 commits into from Mar 11, 2015

Conversation

Projects
None yet
3 participants
@cchalmers
Copy link
Member

commented Mar 9, 2015

@byorgey

This comment has been minimized.

Copy link
Member

commented Mar 10, 2015

I took a careful look through the changes and this all looks good to me. Though I fully support renaming (|>) so as not to conflict with lens, I can't say I'm a huge fan of (>|). What about (.>>)? So it's reminiscent of (.>) which takes a name on the left and the right, whereas (.>>) would take a name on the left and something more complicated (potentially something full of lots of names) on the right.

@byorgey byorgey referenced this pull request Mar 10, 2015

Merged

Pre 1.3 #241

@bergey

This comment has been minimized.

Copy link
Member

commented Mar 10, 2015

Why remove instance Wrapped Name?

Other than that and the naming decision, LGTM. Thanks for splitting this up; it makes it much easier for me to understand & review.

@cchalmers

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2015

Using (.>>) sounds good to me. It overlaps with function from Biapply from bifunctors but no one uses it :)

I'm not sure why I removed the Wrapped instance. I'll add it again.

@cchalmers

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2015

Thanks for splitting this up; it makes it much easier for me to understand & review.

I've recently discovered git rebase -i so I can make all my PRs pretty :)

bergey added a commit that referenced this pull request Mar 11, 2015

Merge pull request #82 from diagrams/pre-1.3
Show & Representable instances; rename |> to .>>

@bergey bergey merged commit 1d3d6ad into master Mar 11, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.