Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set ID prefixes #71

Merged
merged 1 commit into from Feb 9, 2015

Conversation

Projects
None yet
3 participants
@mightybyte
Copy link
Contributor

commented Feb 8, 2015

Without this, separately generated diagrams displayed on the same page can
conflict and display incorrectly.

Allow user to set ID prefixes
Without this, separately generated diagrams displayed on the same page can
conflict and display incorrectly.

jeffreyrosenbluth added a commit that referenced this pull request Feb 9, 2015

Merge pull request #71 from mightybyte/master
Allow user to set ID prefixes

@jeffreyrosenbluth jeffreyrosenbluth merged commit 1b8a8d2 into diagrams:master Feb 9, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@jeffreyrosenbluth

This comment has been minimized.

Copy link
Member

commented Feb 9, 2015

Thanks Doug, looks good

@cchalmers

This comment has been minimized.

Copy link
Member

commented Feb 9, 2015

Could we make the default prefix (for render functions and command line generation) the basename of the output file and have primed versions of renderSVG and renderPretty that take a Options SVG V2 n?

@jeffreyrosenbluth

This comment has been minimized.

Copy link
Member

commented Feb 9, 2015

@cchalmers
I think that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.