Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs Page #6

Closed
wants to merge 0 commits into from

Conversation

2 participants
@AndreiUshakov
Copy link
Contributor

commented May 30, 2019

No description provided.

@lgtm-com

This comment has been minimized.

Copy link

commented May 30, 2019

This pull request introduces 18 alerts when merging a47028d into 6849126 - view on LGTM.com

new alerts:

  • 16 for Unused variable, import, function or class
  • 1 for Unreachable statement
  • 1 for Potentially inconsistent state update

Comment posted by LGTM.com

@lgtm-com

This comment has been minimized.

Copy link

commented Jun 4, 2019

This pull request introduces 36 alerts when merging b232138 into 6849126 - view on LGTM.com

new alerts:

  • 34 for Unused variable, import, function or class
  • 1 for Unreachable statement
  • 1 for Potentially inconsistent state update
@@ -32,8 +33,8 @@ const config = {
host: env('HOST', '0.0.0.0'),
},
ghost: {
endpoint: env('GHOST_ENDPOINT', null),
apiKey: env('GHOST_API_KEY', null),
endpoint: env('GHOST_ENDPOINT', 'https://georgetokmakov.ghost.io'),

This comment has been minimized.

Copy link
@olegshilov

olegshilov Jun 4, 2019

Member

revert this and next line

checkOrFail('MAILCHIMP_KEY', config.mailchimp.key);
checkOrFail('MAILCHIMP_LIST_RU', config.mailchimp.list.ru);
checkOrFail('MAILCHIMP_LIST_EN', config.mailchimp.list.en);
//checkOrFail('MAILCHIMP_KEY', config.mailchimp.key);

This comment has been minimized.

Copy link
@olegshilov
.vacancies__filter {
margin: 30px 0;

.category_filter {

This comment has been minimized.

Copy link
@olegshilov

olegshilov Jun 4, 2019

Member

it will not work, you need to use an ampersand for nesting
https://github.com/postcss/postcss-nested

@@ -6,7 +6,7 @@
"private": "true",
"scripts": {
"server": "node server/server",
"start": "gatsby develop -H 0.0.0.0 -p 8000 & npm run server",
"start": "start npm run server & start gatsby develop -H 0.0.0.0 -p 8000",

This comment has been minimized.

Copy link
@olegshilov

olegshilov Jun 4, 2019

Member

its not working. use npm-run-all instead

@@ -0,0 +1,35 @@
diff a/src/i18n/locales/en.js b/src/i18n/locales/en.js (rejected hunks)

This comment has been minimized.

Copy link
@olegshilov

olegshilov Jun 4, 2019

Member

remove this file from pull request

@olegshilov olegshilov closed this Jun 5, 2019

@olegshilov olegshilov force-pushed the AndreiUshakov:develop branch from c3a804c to b0da773 Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.