Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editable flag for Binder to avoid PEP 517 issue with pip #463

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@matthewfeickert
Copy link
Collaborator

commented May 2, 2019

Description

The postBuild file for Binder is breaking given the issues from pip v19.1 and PEP 517 that happened in PR #455. As Binder doesn't need to have an editable install of pyhf in it this can be resolved by not installing in editable mode, as there is no need for Binder.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
- Follow up to PR #455
- Remove -e flag from pip install in postBuild to have Binder avoid issues with PEP 517 and pip

@matthewfeickert matthewfeickert self-assigned this May 2, 2019

@matthewfeickert matthewfeickert force-pushed the fix/use-no-pep517-on-Binder branch 2 times, most recently from ff60cf2 to 70e9624 May 3, 2019

@matthewfeickert matthewfeickert marked this pull request as ready for review May 7, 2019

@matthewfeickert matthewfeickert force-pushed the fix/use-no-pep517-on-Binder branch from 70e9624 to 637984a May 7, 2019

@matthewfeickert

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

In what I can only describe as Travis CI being really weird and unreliable, earlier the build for this PR was failing from memory errors like that of PR #468. Then, without changing any code, I force pushed to restart a build and everything passes. :? I think moving to GitHub Actions will hopefully be a welcome relief in the future.

@matthewfeickert matthewfeickert requested review from kratsg and lukasheinrich May 7, 2019

@coveralls

This comment has been minimized.

Copy link

commented May 7, 2019

Coverage Status

Coverage remained the same at 93.657% when pulling 637984a on fix/use-no-pep517-on-Binder into 42e6ec8 on master.

@lukasheinrich lukasheinrich merged commit a4aabd5 into master May 7, 2019

5 checks passed

CodeFactor No issues found.
Details
WIP Legacy commit status override — see details
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.657%
Details

@matthewfeickert matthewfeickert deleted the fix/use-no-pep517-on-Binder branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.