Skip to content

Commit

Permalink
Changes for a successful facebook review
Browse files Browse the repository at this point in the history
I had two facebook reviews in the past days
Removing the display type and adding a explicit
'Share to' provider tag did the trick

Signed-off-by: Lukas Matt <lukas@zauberstuhl.de>
  • Loading branch information
Lukas Matt committed Mar 30, 2016
1 parent 0cbb123 commit 267d91b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion app/helpers/publisher_helper.rb
Expand Up @@ -12,9 +12,10 @@ def all_aspects_selected?(selected_aspects)
end

def service_button(service)
share_to = I18n.t "services.index.share_to"
content_tag :div,
class: "btn btn-link service_icon dim",
title: "#{service.provider.titleize} (#{service.nickname})",
title: "#{share_to} #{service.provider.titleize} (#{service.nickname})",
id: "#{service.provider}",
maxchar: "#{service.class::MAX_CHARACTERS}",
data: {toggle: "tooltip", placement: "bottom"} do
Expand Down
1 change: 0 additions & 1 deletion config/initializers/omniauth.rb
Expand Up @@ -13,7 +13,6 @@

if AppConfig.services.facebook.enable?
provider :facebook, AppConfig.services.facebook.app_id, AppConfig.services.facebook.secret, {
display: "popup",
scope: "public_profile,publish_actions",
client_options: {
ssl: {
Expand Down
1 change: 1 addition & 0 deletions config/locales/diaspora/en.yml
Expand Up @@ -1171,6 +1171,7 @@ en:
really_disconnect: "Disconnect %{service}?"
edit_services: "Edit services"
services_explanation: "Connecting to third-party sharing services gives you the ability to publish your posts to them as you write them in diaspora*."
share_to: "Share to"
create:
success: "Authentication successful."
failure: "Authentication failed."
Expand Down

0 comments on commit 267d91b

Please sign in to comment.