New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post to facebook broken for some users #2882

Closed
dmorley opened this Issue Feb 12, 2012 · 15 comments

Comments

Projects
None yet
8 participants
@dmorley
Contributor

dmorley commented Feb 12, 2012

I was sure there was a bug for this, verified on jd and diasp that post to facebook function does not make it out to facebook. Was broken during the backbone.js change out last month.

@DeadSuperHero

This comment has been minimized.

Member

DeadSuperHero commented Feb 12, 2012

Yeah, I can confirm this as well from the JD.com pod. I think Twitter and Tumblr posting still work, though.

@sarahmei

This comment has been minimized.

Member

sarahmei commented Feb 13, 2012

Weird. Facebook posting is working for me on joindiaspora.com. Twitter is working too. I'm not connected to Tumblr.

@dmorley

This comment has been minimized.

Contributor

dmorley commented Feb 13, 2012

I dropped and reauthed fb on both pods to see if maybe they lost the oauth somehow, no luck.

@dmorley

This comment has been minimized.

Contributor

dmorley commented Feb 13, 2012

ok I figured it out. I went to the app permissions in facebook and give diaspora access to make a public post and not just a post to friends only. I don't allow anything public in/on/around facebook so my limited permissions end up on failure. I suppose that is not a bug per say, but we have lots of confused users thinking its broken.

@sarahmei

This comment has been minimized.

Member

sarahmei commented Feb 13, 2012

How do you think we should fix it?

@dmorley

This comment has been minimized.

Contributor

dmorley commented Feb 13, 2012

I guess really right now it should fail when getting the facebook auth, it basicly gets auth for permissions it can not use. So rather than return a success it should return failure and not add the connection?

@jackaponte

This comment has been minimized.

jackaponte commented Feb 13, 2012

@dmorley – not sure I understand your fix, but I've noticed that posting to Facebook from Diaspora is not working for me, either. On Facebook the Diaspora app is set to post visible to Friends only; are you saying that you had to allow Diaspora to make public posts on Facebook in order for it to work? (Posting to Twitter from Diaspora is working fine for me, btw.)

@jackaponte

This comment has been minimized.

jackaponte commented Feb 13, 2012

Disconnecting and then reconnecting the Facebook service in Diaspora seems to have resolved the problem; a Limited Diaspora post appeared properly (and quickly) on my Facebook wall.

@dmorley

This comment has been minimized.

Contributor

dmorley commented Feb 14, 2012

So it actually seems pretty smart in its settings, if you make a public post on diaspora and do not allow public post on facebook, the post fails. If you make a aspect only post on diaspora and only allow friend posts on facebook the post works. So really if you go and get auth from facebook and no "public" permissions are granted you could just get a warning that a public diaspora post with the facebook icon checked will not be posted because you have blocked public facebook posts.

@nailbar

This comment has been minimized.

nailbar commented May 21, 2012

Would it be possible to make a public Diaspora post be posted on Facebook as restricted to whatever rules are set there instead of failing? I usually post stuff as public with both Facebook and Twitter ticked and since my initial post is intended to be public it seems silly to have to post the same thing again on Facebook. I don't know how or if it's even possible to give Diaspora access to post public posts on Facebook.

@jaywink

This comment has been minimized.

Contributor

jaywink commented Oct 3, 2012

Have just set up a new pod and cannot get Facebook posting to work. Have tried multiple privacy levels on both sides.

Has anyone had a go at fixing the issue? Might try and have a look but some pointers would be nice if someone has some :)

@jhass

This comment has been minimized.

Member

jhass commented Oct 3, 2012

I'm rather clueless too, creating a post and then doing what app/models/services/facebook.rb does step by step in the rails console and carefully inspecting all returns/responses might reveal something.

@hfase01

This comment has been minimized.

Contributor

hfase01 commented Oct 3, 2012

I noticed they fixed all that on Makr.io a long time ago if you want to compare the code. ;) It is a little over my head though..

@jaywink

This comment has been minimized.

Contributor

jaywink commented Oct 4, 2012

@maxwell any tips on how it was fixed for Makr.io? Seems like totally rewritten so cannot really compare separate lines.

Will have a look today at hacking on this hopefully.

@jaywink

This comment has been minimized.

Contributor

jaywink commented Nov 6, 2012

This should be fixed by #3698

@jhass jhass closed this Nov 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment