Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show users, if a contact is following them back #2948

Closed
lu-x opened this issue Feb 28, 2012 · 10 comments
Closed

show users, if a contact is following them back #2948

lu-x opened this issue Feb 28, 2012 · 10 comments

Comments

@lu-x
Copy link

@lu-x lu-x commented Feb 28, 2012

this could be done on the profile pages.

@Strubbl
Copy link

@Strubbl Strubbl commented Mar 6, 2012

I like this idea, too.

@jhass
Copy link
Member

@jhass jhass commented Sep 22, 2012

This should be as easy as adding a view helper fetching the contact for the given person and current_user and if there's one check the sharing flag on it. Check out the contact_for and has_contact_for? methods in the user model. Then a nice UI is needed ;)

@davexunit
Copy link

@davexunit davexunit commented Jun 19, 2013

So, if contact.sharing?, show some sort of indication that this contact is also sharing with us.

What pages should this be on? The OP mentions "profile pages", but when we view a user's profile, it's obvious if they are sharing with us or not because their stream will be visible/hidden. Do you mean the contacts page perhaps?

@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Jun 19, 2013

@davexunit it's not obvious, you can see the profile of someone without any sharing (you'll see only public post). You can know if you are sharing with the person looking at the aspect dropdown, but you have currently no way on this page to know if this person is sharing with you. So it's a good suggestion.

@jhass
Copy link
Member

@jhass jhass commented Jun 19, 2013

@davexunit On the technical level you're right, if contact.sharing? display a notice.

@davexunit
Copy link

@davexunit davexunit commented Jun 19, 2013

Thanks @Flaburgan that makes sense.

@davexunit
Copy link

@davexunit davexunit commented Jun 19, 2013

What should the UI for this look like?

@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Jun 19, 2013

I don't know, maybe a sentence under the aspect dropdown?

@davexunit
Copy link

@davexunit davexunit commented Jun 19, 2013

I put a sentence under the profile picture. I just tried throwing the same thing under the aspect dropdown but it doesn't look so good.

@jhass jhass closed this Jun 29, 2013
@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Jul 31, 2013

I could be nice to have this info in the hovercard too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants