Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

the loading gif shouldn't be red, should it? #3338

Closed
ghost opened this Issue · 10 comments

4 participants

@ghost

here's a screenshot ;)

screenshot

@B5r1oJ0A9G

noticed that too!
In my case (Firefox 11) it's only the background of the gif that is red.

@ghost

btw i'm using ff 12 ;)

@DeadSuperHero

I've noticed this on Firefox mobile. Perhaps this is Gecko-specific?

@Raven24
Owner

still happening with Firefox 13 / Linux

@ghost

in chrome everything's normal, so it's ff specific...

@shmerl

Confirming that in Firefox 13. That throbber looks unpleasant in a number of ways besides the red color. And probably no need to use any gifs there. Some JavaScript animation would work fine.

@shmerl

Here is an example which can use hardware acceleration, and supposedly is performing better than any animated GIFs/APNGs:
http://cheeaun.github.com/experiments/animated-loading-indicator/

Here is some more insight:
http://css3.bradshawenterprises.com/

@ghost

looks cool :D

@shmerl

Also, note that the PNG itself is not well crafted:
https://d3mbmfe8268ud7.cloudfront.net/assets/static-loader-dfd0307f51a99655c8f1413a1ffd293e.png
It mixes transparent background with white background, not neatly (open it in Firefox for example, which shows the image with dark background and you'll notice it).

Just to update on the example before - better to use CSS transforms, than JavaScript animation of the sprite, since they are expected to be faster.

@Raven24 Raven24 closed this in 1fb0165
@Raven24
Owner

we were already using css3 animations, there was just, in fact, a red background specified for the spinner... facepalm

@hfase01 hfase01 referenced this issue from a commit in hfase01/diaspora
@Raven24 Raven24 remove leftover edges from spinner, remove red bg color (fixes #3338)…
… [ci skip]
c99e61e
@hfase01 hfase01 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@hfase01 hfase01 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@wenzowski wenzowski referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.