Skip to content
This repository

the loading gif shouldn't be red, should it? #3338

Closed
ghost opened this Issue · 10 comments

4 participants

Marc Sean Tilley Florian Staudacher shmerl
Deleted user
ghost commented

here's a screenshot ;)

screenshot

Marc

noticed that too!
In my case (Firefox 11) it's only the background of the gif that is red.

Deleted user
ghost commented

btw i'm using ff 12 ;)

Sean Tilley
Owner

I've noticed this on Firefox mobile. Perhaps this is Gecko-specific?

Florian Staudacher
Collaborator

still happening with Firefox 13 / Linux

Deleted user
ghost commented

in chrome everything's normal, so it's ff specific...

shmerl
shmerl commented

Confirming that in Firefox 13. That throbber looks unpleasant in a number of ways besides the red color. And probably no need to use any gifs there. Some JavaScript animation would work fine.

shmerl
shmerl commented

Here is an example which can use hardware acceleration, and supposedly is performing better than any animated GIFs/APNGs:
http://cheeaun.github.com/experiments/animated-loading-indicator/

Here is some more insight:
http://css3.bradshawenterprises.com/

Deleted user
ghost commented

looks cool :D

shmerl
shmerl commented

Also, note that the PNG itself is not well crafted:
https://d3mbmfe8268ud7.cloudfront.net/assets/static-loader-dfd0307f51a99655c8f1413a1ffd293e.png
It mixes transparent background with white background, not neatly (open it in Firefox for example, which shows the image with dark background and you'll notice it).

Just to update on the example before - better to use CSS transforms, than JavaScript animation of the sprite, since they are expected to be faster.

Florian Staudacher Raven24 closed this in 1fb0165
Florian Staudacher
Collaborator

we were already using css3 animations, there was just, in fact, a red background specified for the spinner... facepalm

Hans Fase hfase01 referenced this issue from a commit in hfase01/diaspora
Florian Staudacher Raven24 remove leftover edges from spinner, remove red bg color (fixes #3338)…
… [ci skip]
c99e61e
Hans Fase hfase01 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Hans Fase hfase01 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Alexander Wenzowski wenzowski referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.