Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture's albums #3904

Open
dolster opened this issue Jan 26, 2013 · 29 comments

Comments

Projects
None yet
@dolster
Copy link

commented Jan 26, 2013


There is a $105 open bounty on this issue. Add to the bounty at Bountysource.

@jhass

This comment has been minimized.

Copy link
Member

commented Jan 26, 2013

We had them in the early days but they got removed since it's very hard to develop a clean UX while keeping the concept of aspects.

@DeadSuperHero

This comment has been minimized.

Copy link
Member

commented Jan 26, 2013

I don't think it'd be impossible to implement photo albums on Diaspora, but
it's something that would have to far both federation and privacy into
account. Not exactly the easiest thing in the world.

On Saturday, January 26, 2013, Jonne Haß wrote:

We had them in the early days but they got removed since it's very hard to
develop a clean UX while keeping the concept of aspects.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3904#issuecomment-12738543.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

So, we will look at it. This is something I really want too. But no date for the moment.

@Raven24

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

Maybe just add a filter to the stream that only shows ones own "posts with pictures" until we can think of something better ...
It really is a shame D* doesbt have that.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

On diasp.org, there is a link "photo" under the profile photo of everyone and you can see all the pictures uploaded. Mine is here : https://diasp.org/people/e84cba65ced18396/photos

We have to talk to David Morley, he did really great improvements to Diaspora, this should be merged in the master branch

@desyncr

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2013

If you go to any profile and you click on the profile image you'll also be following the /photos url you mentioned. This is currently on joindiaspora.org.

That's far away from the idea of a photo album/albums.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

Yeah of course, this was for answer to Raven idea about a filter.

About a photo album, I have no idea how to deal with aspect and privacy, but about the display, the album page should be the same that the beta profile, which was definitely image oriented. And the new single post view could be used to navigate between images and comment on it. The each image should be a post.

What do you guys think about it ?

@ghost

This comment has been minimized.

Copy link

commented Mar 16, 2013

I think that each album should have the same privacy options as each status has. So each album shell be visible only to the people in chosen aspect.

@Raven24 Raven24 referenced this issue Aug 7, 2013

Closed

Photo Album #4205

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Aug 8, 2013

So each album shell be visible only to the people in chosen aspect.

Yeah, but what about a new contact in this aspect? In diaspora, when you add a contact in an aspect, he can't access to content posted before you add him. Should we have the same behavior with album? That means that the album will not have the same number of pictures for two different persons in the same aspect, that's weird.

But if we give full album access to every new person in the aspect, will you remember that you give access to this album one year before? You know, the one with awesome birthday pics? Now, you add your mum to this aspect, and magically she discovers this album. This is typically the kind of stuff we want to avoid in diaspora*.

So? What should we do?

@svbergerem

This comment has been minimized.

Copy link
Member

commented Aug 8, 2013

@Flaburgan ask the same question on loomio? :-P I'd say we could handle albums like special post. Perhaps give them an ID for that specific album and add the same title and description to all of those posts. When someone wants to see an album we look for all posts with that ID and show all photos in a nice UI. So I'd say the visibility of the different parts of an album (those 'special' posts) should be like the visibility of all other posts.

@jhass

This comment has been minimized.

Copy link
Member

commented Aug 8, 2013

And that's then gets confusing, two of your friends sitting together looking at an album and noticing that one can see photos the other can't, in the same album. Therefore my suggestion to not implement albums, but a nice view for all photos that were shared with filters based on the hashtags in the associated posts.

@goobertron

This comment has been minimized.

Copy link

commented Aug 8, 2013

This definitely sounds as though it need a Loomio discussion!

@ghost

This comment has been minimized.

Copy link

commented Aug 15, 2013

I agree with Jonne, albums and hierarchies like directory hierarchies
are outdated in my opinion: tags are better, simpler and cleaner
approach. Also, we'll not need to create new albums but will see photos
already uploaded and tagged as albums.

08/08/13 01:19 -ում, Jonne Haß-ը գրել է:

And that's then gets confusing, two of your friends sitting together
looking at an album and noticing that one can see photos the other
can't, in the same album. Therefore my suggestion to not implement
albums, but a nice view for all photos that were shared with filters
based on the hashtags in the associated posts.


Reply to this email directly or view it on GitHub
#3904 (comment).

@ghost

This comment has been minimized.

Copy link

commented Oct 19, 2013

Yeah, but what about a new contact in this aspect? In diaspora, when you add a contact in an aspect, he can't access to content posted before you add him. Should we have the same behavior with album?

When I add someone to the aspect, I not only agree, I need him to see my old photos shared with that aspect (:

@goobertron

This comment has been minimized.

Copy link

commented Oct 19, 2013

There's an ongoing Loomio discussion about the best way to organise photos here.

@ghost

This comment has been minimized.

Copy link

commented Jan 15, 2014

Since I cannot post in the discussion at loomio (and I don't think I'm guru enough to bother getting permission) I'll post here. I'd like to add three things:

  1. I completely agree with Balasankars 2nd post in the loomio discussion.
  2. An advantage of a tagged-post system over a directory system is that you can easily put one photo in multiple albums.
  3. As a fix for the problem of adding new contacts, I propose the following: when you're viewing one of your aspects (i.e. the list of people in it), every contact would have a field for setting the point in time after which posts in this aspect are visible to the contact. By default, this time is set to the moment when you added the contact to the aspect, but you could move it back in time.
    It would also make sense then, that, when you remove a contact from an aspect, he would remain there (greyed out), but with another field added, stating the time of removal (unless no post were made to this aspect during his being-in-it).
    Finally, I think it would make sense if the poster could see which aspects he posted a post to (e.g. when hovering over "limited" - this information is already stored anyway, since you can filter your own posts by viewing different aspects). These features combined would make it 100% trackable whether person X can see post Y.
@goobertron

This comment has been minimized.

Copy link

commented Jan 16, 2014

If you want to join the Loomio discussion, just ask for an invite (the blue 'Ask to join group' button on this page).

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2014

@dremodaris you don't need to be a guru of anything to join our community ;)

@withthelemons

This comment has been minimized.

Copy link

commented Feb 10, 2015

This is open since 2013 and still nothing? I honestly don't know how to use Diaspora without this feature.

@ghost

This comment has been minimized.

Copy link

commented Feb 10, 2015

The discussion is now being held at this place, but I bumped it for you :)

@jaywink jaywink added the bounty label Feb 12, 2015

@goobertron

This comment has been minimized.

Copy link

commented Jul 26, 2016

I posted a concept/proposal of how we could handle image collections ('albums') using hashtags (the method agreed in the Loomio vote) here: https://pod.orkz.net/posts/b1bb32d0326101345bc000163e5dbca2 (or append /posts/b1bb32d0326101345bc000163e5dbca2 to your own pod's domain to view it in your own pod).

Look forward to views on the concept and how it can be improved/refined.

@goobertron

This comment has been minimized.

Copy link

commented Aug 2, 2016

Here’s the proposal in full so that people don’t have to visit a link to read it. I think initial discussion about the concept should still take place on that Diaspora post (link in previous comment) or in Loomio, however, rather than here.


I’ve been thinking about how we can implement the decision to use #tags to organise photos.

I’ve drawn up a concept with some mock-ups to illustrate it. This proposal is for a user viewing their own uploaded photos; the filter feature could also be made available when viewing someone else’s photos, with some changes.

First, a word on nomenclature: I’ve used ‘photo’ and ‘album’ below, but it’s worth thinking about what terms we actually use. It might be more appropriate to use ‘image’ instead of ‘photo’, as not every image is a photo; and there might well be a better term we can use instead of ‘album’.

Please note that I’ve only shown three images in the mock-ups to save work, but the examples I give assume the user has uploaded a lot more!

To the current view of uploaded photos, I suggest adding the means to filter uploaded photos according to the tags added to those photos. This could be done by either:

  • Adding a ‘search’ bar to enable filtering of photos. When text is entered into this search bar, it will auto-complete according to the tags set for the images in the view.
  • Showing a list of all the tags added to photos in the view. Clicking on these tags then filters the view by those tags.

Here’s the first mock-up:
Proposed new photos stream

If wanted, these combinations of tag filters can then be saved to create ‘albums’.

Let’s say I want to group the photos from my holiday in France this year. So I set three filters: #holiday #france #2016. When one or more filters has been set, the view changes as follows (I’ve used a pop-up window here):

Proposed new photos album view

The tags I have already set appear at the top, and only the photos which have these three tags are shown in the filtered view. Let’s say 58 photos are included in this set. The other tags (not in the current filter set) which these photos have are shown below each photo.

Additionally, a list is shown underneath of all other tags which photos in this set have, along with the number of photos which also have each tag (e.g. ‘#friends (31)’). The user can click on one of these tags to add it to the filter. When this is done, that tag is added to the top and removed from the list at the bottom, and the photos displayed are filtered accordingly. E.g. if I click ‘#beach’, 19 photos will now be in the filtered stream, and the list of extra tags might read

#sea (8) #friends (7) #beer (3)

Let’s say that #mountains, #restaurant and others disappear from the list because no photo is tagged with both #beach and one of those.

If a user thinks a particular combination of filters makes a useful collection of photos, they can save this to create an ‘album’. I suggest that when the Save button is pressed, a pop-up opens which enables the user to give the ‘album’ a name. When a user has created one or more ‘albums’, the links ‘All photos’ and ‘My albums’ will appear above the main photo stream.

Proposed new photos stream

If I click ‘My albums’, a view containing each of the albums I have saved will be displayed, showing the album name and a cover image (the first image in the album, or we could enable the user to choose a particular image as the cover image).

If someone else is viewing my photos, this heading should read either ‘Albums’ or ‘goob’s albums’.


Related issues

Related issues which are out of the scope of this proposal, but which would be very useful, are:

  1. The ability to add tags to and remove tags from photos after uploading.
  2. The ability to add an already uploaded photo to a post after clicking the camera icon in the publisher.
  3. The option to wrap Markdown around an image when uploading it, perhaps with a pop-up to add alt-text or a caption; and the ability to select where this image will appear in the post by using the cursor in the publisher.
  4. Preventing a photo from being shared outside of the scope which it has been given (perhaps except by the person who uploaded it).

Another thing which might be worth considering is:

  1. The ability to publish images to specific aspects outside of a post.

There’s my idea. I hope it makes sense, and look forward to hearing what you all think of it.

goob

@dcapeletti

This comment has been minimized.

Copy link

commented Dec 3, 2016

Please, more information on this implementation.
I would like to know your current status of implementation. 0%, 10%, 50%, 80%.
Approximately for what year could it be available?

Thanks

@svbergerem

This comment has been minimized.

Copy link
Member

commented Dec 3, 2016

I would like to know your current status of implementation. 0%, 10%, 50%, 80%.

I'd say 0%.

Approximately for what year could it be available?

It could be available this year if someone implements it and opens a pull request. Or maybe no one will ever decide to implement it. I don't know.

@SuperTux88

This comment has been minimized.

Copy link
Member

commented Dec 3, 2016

I would like to know how useful this comment was: 0%, 10%, 50%, 80%.

@svbergerem

This comment has been minimized.

Copy link
Member

commented Dec 3, 2016

I can haz 100%? Please?

@SuperTux88

This comment has been minimized.

Copy link
Member

commented Dec 3, 2016

@svbergerem your comment was 100% useful 👍

@dcapeletti what do you expect from such comments? A feature is done when it's done. And if nobody implements it, it's never done. The last comment from @goobertron is the current state ... so no need to ask.

@piraz

This comment has been minimized.

Copy link

commented Feb 21, 2017

Do we have a complete spec here? I think this is a feature that would be attracting/retaining lots of users.

I would like to use this feature to join as a contributor. Can I have some tutoring on this project?

@goobertron

This comment has been minimized.

Copy link

commented Mar 25, 2018

Hi @piraz. It's great to hear that you'd like to contribute.

I don't think that anything has been completed beyond the initial decision to organise images using #hashtags.

I proposed a more detailed concept (posted above) in August 2016, and there was some discussion to refine that on Loomio. (Note that Loomio discussions were ported to Diaspora's Discourse instance when we stopped using Loomio, but there are some images in the Loomio discussion which didn't make it to Discourse.)

Would you like to work on building a detailed spec for this feature? I'm sure the established developers would help you as much as they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.