New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are out of order #4269

Closed
polsvoice opened this Issue Jun 29, 2013 · 21 comments

Comments

Projects
None yet
10 participants
@polsvoice
Contributor

polsvoice commented Jun 29, 2013

I notice that, many times, comments on posts from JoinDiaspora show up out of order on Diasp.org (or are missing!) This makes it hard to follow conversations. Here is an example from a recent post by Sean Tilley.
Here's how the comments look on JoinDiaspora:
diaspora_screenshot3
On diasp.org:
diaspora_screenshot4
May be related to this issue?


The $80 bounty on this issue has been claimed at Bountysource.

@jhass

This comment has been minimized.

Show comment
Hide comment
@jhass

jhass Aug 1, 2013

Member

We recently discovered that we do not federate the created_at timestamp of comments. Doing that should greatly improve the situation.

Member

jhass commented Aug 1, 2013

We recently discovered that we do not federate the created_at timestamp of comments. Doing that should greatly improve the situation.

@Flaburgan

This comment has been minimized.

Show comment
Hide comment
@Flaburgan

Flaburgan Aug 2, 2013

Member

Nice idea! Does anyone want to work on that?

Member

Flaburgan commented Aug 2, 2013

Nice idea! Does anyone want to work on that?

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Aug 5, 2013

Contributor

I do, it'd be a great way to learn how federation works

Contributor

oliverbarnes commented Aug 5, 2013

I do, it'd be a great way to learn how federation works

@jhass

This comment has been minimized.

Show comment
Hide comment
@jhass

jhass Aug 5, 2013

Member

The only issue is that it is an assumption. We have no way to clearly reproduce the issue to test it.

Member

jhass commented Aug 5, 2013

The only issue is that it is an assumption. We have no way to clearly reproduce the issue to test it.

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Aug 5, 2013

Contributor

How is federated content tested currently? And if not possible presently, would there be a downside to federating the timestamps?

Contributor

oliverbarnes commented Aug 5, 2013

How is federated content tested currently? And if not possible presently, would there be a downside to federating the timestamps?

@jhass

This comment has been minimized.

Show comment
Hide comment
@jhass

jhass Aug 5, 2013

Member

I see no downside to that at all. @Raven24 would you?

We have no reliable testing environment for federation yet, apart from a few developers pods running on the develop branch.

Member

jhass commented Aug 5, 2013

I see no downside to that at all. @Raven24 would you?

We have no reliable testing environment for federation yet, apart from a few developers pods running on the develop branch.

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Aug 5, 2013

Contributor

Cool, going to dig in to implement this then, and try to think about ways to test this in a viable way

Contributor

oliverbarnes commented Aug 5, 2013

Cool, going to dig in to implement this then, and try to think about ways to test this in a viable way

@skogshjort

This comment has been minimized.

Show comment
Hide comment
@skogshjort

skogshjort Oct 18, 2013

@oliverbarnes How is it going? Any progress on this? :)

@oliverbarnes How is it going? Any progress on this? :)

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Oct 21, 2013

Contributor

@skogshjort unfortunately no, ran out of time to dedicate to diaspora back then. I'm coming back this week though. Were you interested on working on this?

Contributor

oliverbarnes commented Oct 21, 2013

@skogshjort unfortunately no, ran out of time to dedicate to diaspora back then. I'm coming back this week though. Were you interested on working on this?

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Nov 2, 2013

Contributor

@MrZYX back with some time to contribute, but behind on the state of affairs. is this a current issue, or are there more pressing things I could help with?

Contributor

oliverbarnes commented Nov 2, 2013

@MrZYX back with some time to contribute, but behind on the state of affairs. is this a current issue, or are there more pressing things I could help with?

@Flaburgan

This comment has been minimized.

Show comment
Hide comment
@Flaburgan

Flaburgan Nov 2, 2013

Member

This is an important issue so it's nice if you work on that.

Member

Flaburgan commented Nov 2, 2013

This is an important issue so it's nice if you work on that.

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Nov 3, 2013

Contributor

@Flaburgan cool, I'm working on #3664 , and once I'm done I'll pick this one up again

Contributor

oliverbarnes commented Nov 3, 2013

@Flaburgan cool, I'm working on #3664 , and once I'm done I'll pick this one up again

@svbergerem

This comment has been minimized.

Show comment
Hide comment
@svbergerem

svbergerem Jan 12, 2014

Member

Still an important issue. Just found another example: This is the same comment on three different pods
comments_out_of_order

Member

svbergerem commented Jan 12, 2014

Still an important issue. Just found another example: This is the same comment on three different pods
comments_out_of_order

@oliverbarnes

This comment has been minimized.

Show comment
Hide comment
@oliverbarnes

oliverbarnes Jan 13, 2014

Contributor

@svbergerem @Flaburgan Sorry but I haven't had the time to dedicate to this issue. Anybody else interested, please feel free to take it over

Contributor

oliverbarnes commented Jan 13, 2014

@svbergerem @Flaburgan Sorry but I haven't had the time to dedicate to this issue. Anybody else interested, please feel free to take it over

@polsvoice

This comment has been minimized.

Show comment
Hide comment
@polsvoice

polsvoice Jan 23, 2014

Contributor

Here's a related(?) post: this one is over a month old, and hasn't updated with comments yet. Of the 9 comments posted (all ~a month old), zero have transferred over to diasp.org. Note also that the old name "Diaspora HQ" is still displayed on diasp.org (instead of the updated, lowercase "diaspora* hq").

https://joindiaspora.com/posts/3446648
https://diasp.org/posts/2597401

Contributor

polsvoice commented Jan 23, 2014

Here's a related(?) post: this one is over a month old, and hasn't updated with comments yet. Of the 9 comments posted (all ~a month old), zero have transferred over to diasp.org. Note also that the old name "Diaspora HQ" is still displayed on diasp.org (instead of the updated, lowercase "diaspora* hq").

https://joindiaspora.com/posts/3446648
https://diasp.org/posts/2597401

@Flaburgan

This comment has been minimized.

Show comment
Hide comment
@Flaburgan

Flaburgan Apr 3, 2014

Member

Looks like it's not only comment, I just had the problem in the private messages:
capture du 2014-04-03 10 40 13
My message is displayed after his answer.

The weird thing is, it's only with one other person in the conversation: it's obvious that my message was written first, and we can't say that my pod received the answer first, because I wrote it on the pod itself before (my message was not federated to my own pod). Maybe it's a clock problem of my server? Looks like it's not federation fault.

Member

Flaburgan commented Apr 3, 2014

Looks like it's not only comment, I just had the problem in the private messages:
capture du 2014-04-03 10 40 13
My message is displayed after his answer.

The weird thing is, it's only with one other person in the conversation: it's obvious that my message was written first, and we can't say that my pod received the answer first, because I wrote it on the pod itself before (my message was not federated to my own pod). Maybe it's a clock problem of my server? Looks like it's not federation fault.

@goobertron

This comment has been minimized.

Show comment
Hide comment
@goobertron

goobertron Apr 3, 2014

This happened to me the other day – in a conversation in which you were involved, Fla, so maybe it's you [stern look].

I had started a conversation, received an email notification that one of the participants had replied (with two messages in total), went back to the conversation and posted a response. When I did this, my response appeared above the two messages about which I had been notified before I responded. Like Fla, this was a conversation started by me, so on my pod, and as my pod had already notified me of the other person's replies, it had obviously received the messages itself.

I've never noticed it before - not that I've used the conversations system a huge amount - but the fact that it's happened to me and to Fla within the space of a few days suggests it might be recent problem. The pod I'm on runs 0.3.0.3.

This happened to me the other day – in a conversation in which you were involved, Fla, so maybe it's you [stern look].

I had started a conversation, received an email notification that one of the participants had replied (with two messages in total), went back to the conversation and posted a response. When I did this, my response appeared above the two messages about which I had been notified before I responded. Like Fla, this was a conversation started by me, so on my pod, and as my pod had already notified me of the other person's replies, it had obviously received the messages itself.

I've never noticed it before - not that I've used the conversations system a huge amount - but the fact that it's happened to me and to Fla within the space of a few days suggests it might be recent problem. The pod I'm on runs 0.3.0.3.

@JannikStreek

This comment has been minimized.

Show comment
Hide comment
@JannikStreek

JannikStreek Apr 3, 2014

Contributor

I will have a look at this in the next couple of days.

Contributor

JannikStreek commented Apr 3, 2014

I will have a look at this in the next couple of days.

@goobertron

This comment has been minimized.

Show comment
Hide comment
@goobertron

goobertron Oct 5, 2014

An example of the extent of comments not federating. The same post on orkz.net and diasp.org

https://pod.orkz.net/posts/1512224
https://diasp.org/posts/3570058

These problems always seem to involve diasp.org - perhaps a pod-specific issue?

An example of the extent of comments not federating. The same post on orkz.net and diasp.org

https://pod.orkz.net/posts/1512224
https://diasp.org/posts/3570058

These problems always seem to involve diasp.org - perhaps a pod-specific issue?

@jhass jhass added the bounty label Feb 28, 2015

@Flaburgan

This comment has been minimized.

Show comment
Hide comment
Member

Flaburgan commented May 28, 2015

@JannikStreek any news?

@cmrd-senya cmrd-senya referenced this issue in diaspora/diaspora_federation Nov 11, 2015

Merged

Add signature computation for entities support #13

@SuperTux88 SuperTux88 referenced this issue in diaspora/diaspora_federation Feb 6, 2016

Closed

Relayable signature refactoring #26

2 of 2 tasks complete

SuperTux88 added a commit to diaspora/diaspora_federation that referenced this issue Mar 8, 2016

SuperTux88 added a commit to SuperTux88/diaspora_federation that referenced this issue Jun 5, 2017

@SuperTux88 SuperTux88 referenced this issue in diaspora/diaspora_federation Jun 5, 2017

Merged

Add created_at to comment #67

@SuperTux88

This comment has been minimized.

Show comment
Hide comment
@SuperTux88

SuperTux88 Jul 14, 2017

Member

Fixed with #7436

Member

SuperTux88 commented Jul 14, 2017

Fixed with #7436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment