Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a pull request #4340

Open
jhass opened this issue Aug 1, 2013 · 7 comments
Open

Adopt a pull request #4340

jhass opened this issue Aug 1, 2013 · 7 comments
Labels

Comments

@jhass
Copy link
Member

@jhass jhass commented Aug 1, 2013

This issue keeps track of (seemingly) abandoned pull requests. Adopting them is very welcome!

Some cavehats though: Carefully read the associated discussions, don't forget the ones in the associated issues. There always is a reason a pull request is unmerged. Make sure to get some feedback about the solution you would apply to solve the outstanding issue first. Also reassure that the issue still exists, if not please tell us about that.

You can find the adoptable pull requests under the orphan label: https://github.com/diaspora/diaspora/labels/orphan

Here's the git fu to get you started:

  1. Locate the location of the branch of the pull request, at the top you can read "Somebody wants to merge n commits into diaspora:develop from somebody:something. The somebody:something is the important piece of information. somebody is the repository owner, something the branch name.

  2. Assuming you forked Diaspora already, cloned your fork and have a shell open placed at your repository, run the following commands:

    git remote add somebody git://github.com/somebody/diaspora.git
    git fetch somebody
    git checkout -b something somebody/something
    git push -u origin something

    Replace somebody and something accordingly.

  3. You now have a something branch of the pull request, make any needed changes inside the branch and push them. Once you're done or need some feedback open a new pull request from the branch in your fork.

@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Dec 24, 2013

I don't know if @taratatach will fix the failing test in #4527

@Amritha777
Copy link

@Amritha777 Amritha777 commented Feb 25, 2018

@jhass I am interested in contributing to this project as a part of my RGSoC application. Is this issue still open?And please do guide me with some details on how to start the fix

@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Feb 25, 2018

@Amritha777 this issue is constantly open as PR sometimes get abandoned. Please tell us on what task you'd like to work ;)

@Amritha777
Copy link

@Amritha777 Amritha777 commented Feb 25, 2018

@Flaburgan me and my teammate are well versed with front-end utilities HTML CSS Javascript etc.
Though we are keen on learning ruby on rails through the journey of contribution ( our coaches will be guiding us with ruby on rails). So as a newcomer, I would love to work on front-end UI based tasks!

@Amritha777
Copy link

@Amritha777 Amritha777 commented Feb 25, 2018

@Flaburgan
Copy link
Member

@Flaburgan Flaburgan commented Feb 25, 2018

Awesome! If you didn't do it already, start by reading our wiki page for new contributors. Then digs into the issues with the newcomer or the help wanted label. If you have a question specific to an issue, post on github, if you have a generic question (like if you need help to set up your development environnement) please join #diaspora or #diaspora-dev on IRC freenode.

Also, if you don't have an account on diaspora already, you can register on my pod with this invitation link. I run the develop branch with all the very last commits, so you'll find your work available quickly for you to use. And maybe using diaspora* will help you choose what you want to improve ;)

Welcome aboard!

@denschub
Copy link
Member

@denschub denschub commented Feb 26, 2018

@Amritha777 if this is in regards to Rails Girls Summer of Code, please talk to Lisa first. Her contact details are visible in the application system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.