Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics: rememberable means that last_sign_in_at is not updated #4734

Closed
wiegelmann opened this issue Jan 23, 2014 · 9 comments · Fixed by #4802

Comments

@wiegelmann
Copy link

commented Jan 23, 2014

@jaywink For a better statistic we should ensure that last_sign_in_at is updated each time a user logs in, regardless of whether they used a form to login or were automatically logged in by the rememberable cookie. Currently the last_sign_in_at attribute is only updated when an actual form log in event occurs.

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2014

Ha - that will surely make the graphs better a bit better :)

Anyone object to this change?

@jhass

This comment has been minimized.

Copy link
Member

commented Jan 23, 2014

I see no obvious implications but it would probably best to check back with the Devise people.

@rsofaer

This comment has been minimized.

Copy link
Member

commented Jan 23, 2014

I think we'd have to put a before filter on every request to update that field.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 29, 2014

We just received a mail on press@diasporafoundation.org which asks how many users are using diaspora*. It would be nice to have this fixed and the invitation accounts on joindiaspora removed to have a better idea of the activity on the network.

@goobertron

This comment has been minimized.

Copy link

commented Feb 4, 2014

Would it be better to transfer this issue to https://github.com/jaywink/diaspora-hub/issues , as that's where the code is based?

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2014

This problem is in the diaspora core statistics code, not in the hub :)

@goobertron

This comment has been minimized.

Copy link

commented Feb 4, 2014

Ah, ok. Apologies. Ignore me then!

jaywink added a commit to jaywink/diaspora that referenced this issue Feb 12, 2014
jaywink added a commit to jaywink/diaspora that referenced this issue Feb 12, 2014
@itais

This comment has been minimized.

Copy link

commented Feb 18, 2014

It would be nice to have this fixed, most logins probably occur using the cookie. The current statistics imply that 99% percent of users who register leave diaspora (1 million users, 10k active).
Just for fun I tried to make a more accurate estimation from other available stats and came up with ~32k active in the past two weeks.

jaywink added a commit to jaywink/diaspora that referenced this issue Feb 22, 2014
Add devise_lastseenable for user last seen tracking.
Adds a timestamp to user model which is touched when user comes back. Statistics active users counts now use these more reliable timestamps. Fixes diaspora#4734

@jhass jhass closed this in #4802 Feb 23, 2014

Flaburgan added a commit to Flaburgan/the-federation.info that referenced this issue Sep 18, 2014
Remove warning about the last seen bug fixed in 0.4
Now that 0.4.1.0 is out, we can remove this warning, most of the pods upgraded already.

You can want to add the 0.4.0.0 milestone to the issue diaspora/diaspora#4734 in the diaspora repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.