[Develop] It's not possible to rename an aspect anymore #4822

Closed
Flaburgan opened this Issue Mar 3, 2014 · 3 comments

Comments

Projects
None yet
4 participants
@Flaburgan
Member

Flaburgan commented Mar 3, 2014

I suspect upgrade to JQuery 1.10 here.

Steps to reproduce:
Go to the /contacts page
Click on an aspect on the left menu
Click on the manage button
Click on the "rename" link.

Actual results: nothing
Expected results: an input should appear to allow users to rename the aspect (see previous version)

I guess this is develop but I didn't test on 0.3.0.2 nor 0.3.0.3. Everything is fine on joindiaspora running 0.3.0.1

@jaywink

This comment has been minimized.

Show comment Hide comment
@jaywink

jaywink Mar 3, 2014

Contributor

iliketoast.net runs f54931c from Feb 21, before the jQuery upgrade and aspect renaming works fine.

Contributor

jaywink commented Mar 3, 2014

iliketoast.net runs f54931c from Feb 21, before the jQuery upgrade and aspect renaming works fine.

@jaywink jaywink added bug labels Mar 3, 2014

@fabianrbz

This comment has been minimized.

Show comment Hide comment
@fabianrbz

fabianrbz Mar 4, 2014

Contributor

the problem is with a binding, this should be included in some backbone view...
but, changing #aspect_name_title with document here should do the trick

Contributor

fabianrbz commented Mar 4, 2014

the problem is with a binding, this should be included in some backbone view...
but, changing #aspect_name_title with document here should do the trick

@Flaburgan

This comment has been minimized.

Show comment Hide comment
@Flaburgan

Flaburgan Mar 5, 2014

Member

Good guess @fabianrbz
Pull request submitted.

Member

Flaburgan commented Mar 5, 2014

Good guess @fabianrbz
Pull request submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment