Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos - CSS floats causes ugly spaces when using different image sizes #6809

Closed
codesune opened this issue Apr 20, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@codesune
Copy link

commented Apr 20, 2016

This applies to the photos page. Grid style is broken in the new layout (0.6.0.0 milestone), when different image sizes come into play. The reason for this is that floats without fixed heights are used.

See attached screenshot:

photos-issue


The $15 bounty on this issue has been claimed at Bountysource.

@jhass jhass added this to the 0.6.0.0 milestone Apr 20, 2016

@Flaburgan

This comment has been minimized.

Copy link
Member

commented May 18, 2016

I'm going to work on this one.

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue May 18, 2016

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue May 18, 2016

@Flaburgan

This comment has been minimized.

Copy link
Member

commented May 19, 2016

PR opened #6838

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue Aug 8, 2016

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue Aug 8, 2016

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue Aug 8, 2016

Flaburgan added a commit to Flaburgan/diaspora that referenced this issue Aug 8, 2016

@svbergerem svbergerem closed this in eac051f Aug 8, 2016

svbergerem pushed a commit that referenced this issue Aug 8, 2016

Steffen van Bergerem
Merge pull request #6838 from Flaburgan/masonry-photo
Set fixed height of tile in photos stream, fix #6809

@jhass jhass added the bounty label Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.