Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll display "1 vote" when 0% #6835

Closed
SansPseudoFix opened this issue May 17, 2016 · 10 comments

Comments

Projects
None yet
6 participants
@SansPseudoFix
Copy link
Contributor

commented May 17, 2016

Expected: 0 vote -> 0%

Test on diaspora-fr.org, version 0.5.99.0-p8e47632d

bug_poll

Ping @Flaburgan

@Flaburgan

This comment has been minimized.

Copy link
Member

commented May 17, 2016

As I wrote #6641 I'll have a look at this one, please assign me.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented May 19, 2016

Okay so I checked that and it comes from the local. @SansPseudoFix you should be able to confirm that by setting diaspora* to english and see 1 vote becomes 0 vote. However, I didn't find the answer_count segment on webtranslateit, @jhass can you please update the website?

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2016

@SansPseudoFix you should be able to confirm that by setting diaspora* to english and see 1 vote becomes 0 vote.

Oh, you're right.

@denschub

This comment has been minimized.

Copy link
Member

commented May 21, 2016

please assign me.

Impossible, GitHub does not allow non-team-member assignees. Writing a comment is enough, though. :)

I didn't find the answer_count segment on webtranslateit

We used to push only stable translation to wti, but since we should start polishing 0.6.0.0, I've decided to push the develop locales. You should find the translations up after wti is done importing, which should take a only few minutes.

@svbergerem

This comment has been minimized.

Copy link
Member

commented Jun 29, 2016

1 vote french

This plural form is used for numbers like: n in 0..1

@svbergerem svbergerem added this to the 0.6.0.0 milestone Jun 29, 2016

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jun 29, 2016

Why does the indication not match the english one? (1 at the left, 0..1 at the right)

@goobertron

This comment has been minimized.

Copy link

commented Jul 9, 2016

I haven't looked at a poll for a while, but I thought the figure for votes given next to the percentage is for total votes placed on the poll, not the number of votes for that option. Thus it is to be read as 'Nope - 0% of 1 total vote on this poll', not 'Nope - 0% which equals 1 vote'.

If I'm correct, this isn't a bug as it is the way it has been coded. It is, however, a little confusing, and would make sense to list the number of votes for each answer next to that answer, rather than the figure of total votes on the poll (which is, in any case, given above).

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jul 10, 2016

@goobertron the bug is not present in the english language, it's a translation problem. And the number represents the number of votes for this option, not the total of votes ;)

@jhass jhass added the 🌐 i18n label Jul 11, 2016

@jhass

This comment has been minimized.

Copy link
Member

commented Jul 11, 2016

Locales updated, @Flaburgan could you verify?

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jul 11, 2016

Problem fixed! Thank you everyone!

@jhass jhass closed this Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.