Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop target="_blank" for same pod links #7907

Open
jhass opened this issue Oct 25, 2018 · 1 comment
Open

Drop target="_blank" for same pod links #7907

jhass opened this issue Oct 25, 2018 · 1 comment
Labels
✨ feature newcomer

Comments

@jhass
Copy link
Member

jhass commented Oct 25, 2018 •
edited

With the diaspora:// links getting traction, it becomes apparent that we shouldn't force a new window for links that stay on the site.

For the desktop rendering this should be a simple as conditioning https://github.com/diaspora/diaspora/blob/develop/app/assets/javascripts/app/helpers/text_formatter.js#L33

For mobile rendering modifying https://github.com/diaspora/diaspora/blob/develop/lib/diaspora/markdownify/html.rb to add the target conditionally in the link_attribute_blockmight work out
@ibrahimmohelsayed
Copy link

Can I take this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature newcomer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhass @ibrahimmohelsayed