No description provided.
Added a post conversion hook to PageDown to add target="_blank" (fixes …
Merge remote branch 'upstream/master'
Added test for adding target=_blank to autolinks
thanks for the pull request! but could you provide an explanation of what this does exactly?
Oops! It adds target="_blank" to every autolinked link within markdown'd text. For example the comment below:
Hey everyone check out www.russianwives.com
Hey everyone check out <a href="www.russianwives.com" target="_blank">www.russianwives.com</a
Thus fixing for this issue: #2792 (test included)
The regular expression detects urls with well-formed domains, with or without protocol (http/https), with or without querystring parameters but not relative links (ie hashtags and mentions) - so links within the pod will not open a new window.
whats the bit with the pagedown?
Read more here:
heh, sorry wasnt thinking straight...
I am going to pull this, but in the future, if you could make the behavior be testing in a separate test, that way we have some documentation of what everything does!
Alright will do! Thanks maxwell.
Thanks, I have reused this piece of code in a project.