Legacy browser support #2976

Merged
merged 4 commits into from Mar 10, 2012

Projects

None yet

2 participants

@jbivins

Fixes problems when viewing your stream in Safari 4.1.3.

The post order would appear reversed and the infinite scroll would not work.

Joe Bivins added some commits Mar 3, 2012
Joe Bivins Add ISO 8601 timestamp parsing for legacy browsers.
Would cause legacy browsers (e.g. Safari 4.1.3) to show posts in the
reverse order and the infinite scroll would not be triggered when
scrolling down to the end of the page.
4769a25
Joe Bivins Correct JS error in app_spec.js e26fcf8
Joe Bivins Wrap the publisher params tag in a div instead of a paragraph.
Safari 4.1.3 cited the closing params tag as being an unmatched tag.
Changing the paragraph to a div causes the error to disappear.
8df0bb8
@jbivins

Yeah, you're right. There is an existing helper in public/javascripts/app/helpers/text_formatter.js that adds a helper to apps.helpers and JavaScript models use that. I could create something similar, make a date_formatter.js helper, and have models use it in a similar fashion.

@maxwell maxwell commented on the diff Mar 6, 2012
app/views/shared/_publisher.html.haml
@@ -12,7 +12,7 @@
.content_creation
= form_for(StatusMessage.new) do |status|
= status.error_messages
- %p
+ %div
@maxwell
maxwell Mar 6, 2012

is this related to the bugfix? the publisher is so wonky that I am actually sorta nervous about this change...

@jbivins
jbivins Mar 7, 2012

No. It was a separate fix for a JavaScript error that I noticed in the Safari error console.

https://poddery.com/custom/github/diaspora-2976-unmatched-tags-error.gif

If you omit that change, the main problem of the posts appearing in the reverse order will still be corrected. The older version of Safari appears to operate fine with the particular change omitted.

@maxwell maxwell merged commit 0d5c518 into diaspora:master Mar 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment