Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

finally (hopefully) fix non-ascii urls + new & old tests #3084

merged 1 commit into from Mar 29, 2012


None yet
3 participants

Raven24 commented Mar 29, 2012

fix #3082
fix #3081 (+ tests from #3047)


maxwell commented Mar 29, 2012

Thank you so much for fishing that old stuff out again, and thanks for the fix.


maxwell added a commit that referenced this pull request Mar 29, 2012

Merge pull request #3084 from Raven24/non-ascii-begone
finally (hopefully) fix non-ascii urls + new & old tests

@maxwell maxwell merged commit fe1c0d3 into diaspora:master Mar 29, 2012


denniscollective commented Apr 15, 2012

A lot of the tests got moved to a sbubview test somewhere, as this logic is actually the responisbility of the textFormatter, and not the postView could the tests be moved there?


Raven24 commented Apr 15, 2012

sure, can do
... right after my exam tomorrow ;)


denniscollective commented Apr 16, 2012

good luck on the exam!


denniscollective commented Apr 16, 2012

look at stream post spec to make sure there isn't to much redundancy.


Raven24 commented Apr 16, 2012

just pushed the change, should be ok now as it just tests markdownify and doesn't create a whole post each time ;)


denniscollective commented Apr 18, 2012

🌈 Thanks ❤️ ⭐️ 🐴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment