use flash message instead of just appending reshares to the current stream #3190

Merged
merged 2 commits into from Apr 28, 2012

Projects

None yet

4 participants

@Raven24
Owner
Raven24 commented Apr 26, 2012

bug mash item # 1

(fixes #2094)

Owner

Thanks man! You're the best. :)

This pull request fails (merged 0dee8aa into 2b3bc5a).

Owner
Raven24 commented Apr 27, 2012

you're welcome ;)
if there are no objections for the next day or so, I'll merge it

Owner
maxwell commented Apr 27, 2012

tests? :P

Owner
Raven24 commented Apr 27, 2012

DO NOT PULL YET.
I wrote some tests in cucumber, but I can't seem to run them with Firefox 12, Selenium can't establish a connection...
I have to go now, so if anybody else could run them in the meantime, that would be great. Otherwise you'll have to wait until I fixed that Cuke vs. Firefox problem. ;)

Edit: also, I screwed up the commit message... -.-

This pull request fails (merged fba9606 into 2b3bc5a).

Owner
Raven24 commented Apr 27, 2012

hey, I almost forgot, @travisbot is doing testing for PRs now... and it's not faiing because of what I did ;)

This pull request fails (merged 979eb66 into 560da5c).

Owner
Raven24 commented Apr 28, 2012

weird... anybody else having trouble running cucumber with the latest firefox?

@Raven24 Raven24 merged commit 462959f into master Apr 28, 2012
Owner
Raven24 commented Apr 28, 2012

ok, verified my new cukes myself. merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment