Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use flash message instead of just appending reshares to the current stream #3190

Merged
merged 2 commits into from Apr 28, 2012

Conversation

Raven24
Copy link
Member

@Raven24 Raven24 commented Apr 26, 2012

bug mash item # 1

(fixes #2094)

@DeadSuperHero
Copy link
Member

Thanks man! You're the best. :)

@travisbot
Copy link

This pull request fails (merged 0dee8aa into 2b3bc5a).

@Raven24
Copy link
Member Author

Raven24 commented Apr 27, 2012

you're welcome ;)
if there are no objections for the next day or so, I'll merge it

@maxwell
Copy link
Member

maxwell commented Apr 27, 2012

tests? :P

@Raven24
Copy link
Member Author

Raven24 commented Apr 27, 2012

DO NOT PULL YET.
I wrote some tests in cucumber, but I can't seem to run them with Firefox 12, Selenium can't establish a connection...
I have to go now, so if anybody else could run them in the meantime, that would be great. Otherwise you'll have to wait until I fixed that Cuke vs. Firefox problem. ;)

Edit: also, I screwed up the commit message... -.-

@travisbot
Copy link

This pull request fails (merged fba9606 into 2b3bc5a).

@Raven24
Copy link
Member Author

Raven24 commented Apr 27, 2012

hey, I almost forgot, @travisbot is doing testing for PRs now... and it's not faiing because of what I did ;)

@travisbot
Copy link

This pull request fails (merged 979eb66 into 560da5c).

@Raven24
Copy link
Member Author

Raven24 commented Apr 28, 2012

weird... anybody else having trouble running cucumber with the latest firefox?

Raven24 added a commit that referenced this pull request Apr 28, 2012
use flash message instead of just appending reshares to the current stream
@Raven24 Raven24 merged commit 462959f into master Apr 28, 2012
@Raven24
Copy link
Member Author

Raven24 commented Apr 28, 2012

ok, verified my new cukes myself. merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants