Skip to content

BMM #3, “Show x more comments” deletes text in comment box when clicked #3313

Merged
merged 1 commit into from May 25, 2012

3 participants

@OhaiBBQ
diaspora* social network member
OhaiBBQ commented May 25, 2012

persist unsaved comment value after expanding comments

Dan Hansen bugmash #3
persist unsaved comment value after expanding comments
d334097
@travisbot

This pull request passes (merged d334097 into f19f611).

@maxwell
diaspora* social network member
maxwell commented May 25, 2012

I think comments.fetch would be async, since the success callback. wouldn't this still get blown away when the collection finishes?

@OhaiBBQ
diaspora* social network member
OhaiBBQ commented May 25, 2012

No, we render the view after the model has been populated with comments. After the view is re-rendered we set the textbox's value to what the comment used to be.

@maxwell
diaspora* social network member
maxwell commented May 25, 2012

cool. done

@maxwell maxwell merged commit fb1fd66 into diaspora:master May 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.