New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty page after callback from service by redirecting to origin #3693

Merged
merged 1 commit into from Nov 1, 2012

Conversation

Projects
None yet
3 participants
@jaywink
Contributor

jaywink commented Oct 30, 2012

Fixes empty page after authenticating with Facebook by redirecting to origin. In account setup this works correctly to keep the user in the getting started wizard as it should.

Since this breaks production functionality which is used by many of the people who register to Diaspora*, and which gives a very bad feel to how the software works by failing to complete the getting started wizard, I am suggesting this would be merged in as a hotfix.

Fixes #3283

@maxwell

This comment has been minimized.

Member

maxwell commented Oct 30, 2012

I think this might break registering for services from the option page... .i think this actually has to do with the way FF handles script close calls.

@jaywink

This comment has been minimized.

Contributor

jaywink commented Oct 31, 2012

Bummer :P Was in too much of a rush to push and go to bed hehe. This is a pretty major bug as well.

I'll have a look at the tests later and will carefully go through all the pages where service signup can be done (service settings, stream and getting started?). I guess currently some of the times when you click on service signup it launches a popup and sometimes it does it in the current window.

Could we just unify everything to be done in the same window? I assume the callbacks from non-FB services also specify an origin page (or is that in fact handled by omniauth). It's cleaner for the user and avoids problems with popup windows and trying to then close them.

Would this be ok?

@jaywink

This comment has been minimized.

Contributor

jaywink commented Oct 31, 2012

Well now this works nicely on all places, tested all services also from settings -> services and add/remove works fine - no popup needed and is now more unified.

But unfortunately I cannot figure out why the tests fail, if someone has any tips then they are welcome, will try to learn spec stuff meanwhile.. And of course if someone has objections to fixing this this way then ..

EDIT: might have figured it out :)

@jhass

This comment has been minimized.

Member

jhass commented Oct 31, 2012

I think I like it, was no friend of the popup anyway tbh.

Fix empty page after callback from service by redirecting to origin. …
…Also make settings/services page use the same window when authenticating with other services instead of launching a popup.
@jaywink

This comment has been minimized.

Contributor

jaywink commented Nov 1, 2012

Added missing changelog entry.

@jhass

This comment has been minimized.

Member

jhass commented Nov 1, 2012

I'm too lazy to test that right now and will blame you if anything breaks :P Doesn't look too bad after all.

jhass added a commit that referenced this pull request Nov 1, 2012

Merge pull request #3693 from jaywink/feature/3283-empty-page-after-s…
…ervice-callback

Fix empty page after callback from service by redirecting to origin

@jhass jhass merged commit 3aef807 into diaspora:develop Nov 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment