Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix empty page after callback from service by redirecting to origin #3693
Fixes empty page after authenticating with Facebook by redirecting to origin. In account setup this works correctly to keep the user in the getting started wizard as it should.
Since this breaks production functionality which is used by many of the people who register to Diaspora*, and which gives a very bad feel to how the software works by failing to complete the getting started wizard, I am suggesting this would be merged in as a hotfix.
Bummer :P Was in too much of a rush to push and go to bed hehe. This is a pretty major bug as well.
I'll have a look at the tests later and will carefully go through all the pages where service signup can be done (service settings, stream and getting started?). I guess currently some of the times when you click on service signup it launches a popup and sometimes it does it in the current window.
Could we just unify everything to be done in the same window? I assume the callbacks from non-FB services also specify an origin page (or is that in fact handled by omniauth). It's cleaner for the user and avoids problems with popup windows and trying to then close them.
Would this be ok?
Well now this works nicely on all places, tested all services also from settings -> services and add/remove works fine - no popup needed and is now more unified.
But unfortunately I cannot figure out why the tests fail, if someone has any tips then they are welcome, will try to learn spec stuff meanwhile.. And of course if someone has objections to fixing this this way then ..
EDIT: might have figured it out :)