Remove restriction on guid length #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there any conceivable difference between the |
|
Well |
|
In principle I'm totally ok with this, better to introduce this sooner than later. |
|
👍 |
|
alright then, changelog and go ;) |
Raven24
added a commit
that referenced
this pull request
Jun 28, 2013
Remove restriction on guid length
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a request for comments than a pull request
I think it would be a good idea to switch GUID generation to UUIDs: https://github.com/MrZYX/diaspora/compare/uuid However our current database schema limits their length too much, so it would be a change breaking federation, the earliest point where we could do it is the next major release. What we could already do though is removing that restriction, reducing the impact in the migration phase.