Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Change contact list on profile page #4360
This will change the contact list on the profile page. If you look at your own profile a list of 8 contacts will be shown and under the list is a 'see all'-link to your own contacts-page. If you are on another users profile and the user shares a list of contacts with you, you will see the list the same way, with a link to the users contacts-page.
All in all the contacts are now part of the profile information.
referenced this pull request
Aug 7, 2013
Nice work, @svbergerem . Can I just check that this only displays the contacts whom that person has made available to you by ticking 'Make contacts in this aspect visible to each other'? In other words,
It's one of the big ideas of Diaspora that the people each user are in contact with is not known to anyone else. The one exception to this (the only one I'm aware of) is when a person is able to see who else is in a particular aspect that they themselves are in.
@goobertron As most of the code is copy&paste the behavior shouldn't change with this PR. There are three things which change:
I just wrote a cucumber test to make sure that you only see contacts when the aspect list is visible. The test is failing on my machine but so are similar tests too, which work for travis.