Fix drawer in mobile version #4805

Merged
merged 1 commit into from Feb 27, 2014

3 participants

@Flaburgan

This is an attempt to fix #4801
I hope it will also fix different weird behavior in mobile browsers (Firefox for Android and Firefox OS).
It also removes the black background on badges and add a float right on the profile picture in the menu, as users suggested (don't remember where :p)
Btw, I started to split the css code from mobile.css.scss to different files. I put it in the mobile folder in stylesheets, I hope I'll have time to more refactor the css pretty soon.

Enjoy :)

@Flaburgan

It also fixes a bug about the size of the content in screen width > 768px, even if I doubt that these screens would use the mobile version, I don't know much about retina screens etc.

@jhass
diaspora* social network member

So this does a lot more than your commit message describes. Please split it into multiple commits or at least make the message more verbose.

Did you make sure this still works in production? I think rake assets:precompile won't catch mobile.scss anymore if you don't adjust it in config/application.rb.

@Flaburgan Flaburgan Fix drawer in some mobile browsers.
Remove the black background on menu badges.
Fix body content on screen width > 768px.
Start split of mobile css in different files in /mobile/
67d71e2
@Flaburgan

@MrZYX could you tell me what is wrong with travis?

@jhass
diaspora* social network member

Hm? It's green?

@fabianrbz

i restarted a worker that got stuck ;)

@Flaburgan

Thank you! Any remarks about the code?

@jhass jhass merged commit d26ca74 into diaspora:develop Feb 27, 2014

1 check passed

Details default The Travis CI build passed
@jhass
diaspora* social network member

Thank you!

@jhass jhass added this to the next milestone Feb 27, 2014
@Flaburgan Flaburgan deleted the Flaburgan:refactor-mobile-css branch Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment