New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profile page design on mobile #5084

Merged
merged 1 commit into from Aug 27, 2014

Conversation

Projects
None yet
5 participants
@Flaburgan
Copy link
Member

Flaburgan commented Jul 21, 2014

This PR improves the design of the profile user. It was inspired by the design of the hovercard.
Before
before

After
after

The space under the diaspora* ID is here to put the "Add to an aspect" dropdown selector, like on hovercards.

If the username is very long, it goes under. I thought cut it was not a good idea.
long

@DeadSuperHero

This comment has been minimized.

Copy link
Member

DeadSuperHero commented Jul 21, 2014

It's not bad, but I feel like the post elements and the profile elements
look too similar.

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Jul 21, 2014

@DeadSuperHero yeah I have the same feeling, @taratatach proposed to make it full-width, I'll give it a try

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Jul 21, 2014

It doesn't render very well, if someone has another idea...

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Jul 21, 2014

Full width, no margin to the top, no border-radius, bottom box shadow?

It would be awesome if you could add some profile information like we do in the desktop version. (or perhaps someone else in another PR if you don't have enough time to do that)

@goobertron

This comment has been minimized.

Copy link

goobertron commented Jul 21, 2014

Oh, I just posted the same as Sean on your post in Diaspora. How about altering the background of the profile 'card'? Different colours, etc. Also, adding the aspect selector button in the same place as in hovercards would help differentiate this card from the posts below it.

Good luck!

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Aug 27, 2014

capture du 2014-08-27 14 14 57

The place under the diaspora ID is here to add the aspects dropdown selector. Is that better for you?

@Flaburgan Flaburgan force-pushed the Flaburgan:profile-mobile-improvements branch from f038e4b to 1dbce6d Aug 27, 2014

@goobertron

This comment has been minimized.

Copy link

goobertron commented Aug 27, 2014

That looks promising. You could even increase the size of the avatar slightly and decrease the type size of the user name, to give a bit more vertical space below the ID for the aspects dropdown.

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Aug 27, 2014

@goobertron let's adjust that when we will actually add the dropdown ;) Imo it's ready like that.

@goobertron

This comment has been minimized.

Copy link

goobertron commented Aug 27, 2014

I sorry, I thought you were intending to add the drop-down as part of this PR, once people had commented on that new design.

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Aug 27, 2014

Adding the dropdown implies to add all the logic behind it. This PR is only about design.

@jhass

This comment has been minimized.

Copy link
Member

jhass commented Aug 27, 2014

Thank you!

@jhass jhass merged commit 1dbce6d into diaspora:develop Aug 27, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

jhass added a commit that referenced this pull request Aug 27, 2014

Merge pull request #5084 from Flaburgan/profile-mobile-improvements
Improve profile page design on mobile

@jhass jhass added this to the next-major milestone Aug 27, 2014

@Flaburgan Flaburgan deleted the Flaburgan:profile-mobile-improvements branch Jan 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment