Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Increased the number of notifications shown in drop down bar to 15 #5129
perfect-scrollbar looks totally awesome - +1 for that
Thanks for this change @jaideng123 - hugely annoyed myself that we have the 5 notifs limit. Maybe later this can be improved further that it auto-loads more notifications as you scroll down, but this is a very good start to improve the situation.
Hey, you should comment on the PR, not your commits, so we get notifications ;)
The Jasmine tests seem to be fixed by keeping the jquery dependencies in sync:
- gem 'rails-assets-perfect-scrollbar' + gem 'rails-assets-perfect-scrollbar', '0.4.11' + # This should be kept in sync with jquery-rails + gem 'rails-assets-jquery', '1.10.2'
Make sure to commit the changes to Gemfile.lock. Never edit that manually, run bundle (with DB set to nothing or mysql) and commit the changes.
I'm not sure I can follow you on the bootstrap-sass / strong_parameters thing.
Aug 25, 2014
Aug 26, 2014
1 check was pending
added a commit
this pull request
Aug 26, 2014
@jaideng123 Thank you. Just updated my pod and it looks great. On Bootstrap pages (notifications, conversations, settings, ...) the scroll bar is unfortunately missing (not visible) and when you scroll down there is some white space. It would be great if you could try to fix that.