Add Camo support #5386
Add Camo support #5386
Conversation
just a quick proof of concept
yes, we do have Markdown there. But please don't tell anyone.
I just assume camo is cool enough to get an own section.
for mobile views
|
Please don't call methods with |
|
I don't quite follow why you added the processing to both, the getter methods and the message renderer. Are there still places where we hand out the content to the frontend through the getter methods instead of the message renderer? The issue I see is that the getters are used when serializing the object for federation (https://github.com/diaspora/diaspora/blob/develop/app/models/comment.rb#L19). |
| #proxy_remote_pod_images: true | ||
|
|
||
| ## Root of your Camo installation | ||
| #root: "https://camo.example.com/" |
There was a problem hiding this comment.
Total nitpick but I think the example should be https://example.com/camo/ since that's our recommended setup ;)
... and a stealth-commit of an already introduced bug prevention system. ;)
Yeah, we had those. Anyways, I fixed the presenters and removed the getters to prevent federation issues. Thanks for the heads up! |
|
Alright, let's try this. Thank you! |
This pull requests adds optional support for Camo. Camo is a small application to proxy insecure assets over secure channels (mainly markdown images). For more information, check out the wiki page.
The code might need some optimization, please review. Also I'm shamelessly using Travis to ensure my changes have no bad side effects, thus creating this PR. ;)