Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in profile_header_view #5472

Merged
merged 1 commit into from Jan 6, 2015

Conversation

@svbergerem
Copy link
Member

commented Dec 14, 2014

No description provided.

@jhass

This comment has been minimized.

Copy link
Member

commented Dec 14, 2014

Interesting, and that didn't break anything?

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2014

@Raven24 wrote that so perhaps he knows what should have been broken.

@Raven24

This comment has been minimized.

Copy link
Member

commented Dec 14, 2014

I can only guess that the asyncSubHeader may have never been defined where it was important, so the first statement always evaluated to false?

@jhass

This comment has been minimized.

Copy link
Member

commented Dec 14, 2014

This either needs a test exposing the bug, and that not only through specifically mocking everything out so the condition is triggered or, assuming all tests pass afterwards, needs to be just dropped.

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2014

When you start sharing with someone the error console says

TypeError: app.page.asyncSubHeader.resovle is not a function

but the page is still working afterwards.

@svbergerem svbergerem force-pushed the svbergerem:fix-typo-profile-header branch 3 times, most recently from 91bac3b to b3f384a Jan 3, 2015

@svbergerem svbergerem force-pushed the svbergerem:fix-typo-profile-header branch from b3f384a to 59e9597 Jan 3, 2015

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2015

I dropped it and all tests still pass.

@jhass jhass added this to the next-major milestone Jan 6, 2015

jhass added a commit that referenced this pull request Jan 6, 2015

@jhass jhass merged commit d7a3559 into diaspora:develop Jan 6, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jhass

This comment has been minimized.

Copy link
Member

commented Jan 6, 2015

Thanks!

@svbergerem svbergerem deleted the svbergerem:fix-typo-profile-header branch Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.