Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Port contacts page to backbonejs #5473
referenced this pull request
Dec 19, 2014
4 times, most recently
Dec 20, 2014
The only remarks I'd have a more enhancements upon this, which probably are more things for further follow up PRs.
Before we activate the quickfilter on all pages we might want to port the aspect membership dropdown to render it on the client side. (Because I rerender the contacts when the filter is active and that would cause a lot of requests to the server for the dropdowns) Apart from that I agree that both points would be great improvements for follow up PRs.
I fixed some jasmine specs. (They didn't test anything) The specs for the contacts view were broken before and I just moved to broken specs to a new file with my first commit. The specs for the notifications view were also affected. This is why I did those changes in a new commit.
As soon as the Travis build succeeds this should be ready to merge.