New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port contacts page to backbonejs #5473

Merged
merged 2 commits into from Jan 6, 2015

Conversation

Projects
None yet
3 participants
@svbergerem
Copy link
Member

svbergerem commented Dec 14, 2014

No description provided.


def full_hash
base_hash.merge({
relationship: 'yes'

This comment has been minimized.

@jhass

jhass Dec 14, 2014

Member

A bit non-obvious, but I can't come up with a better name. But why no boolean?

This comment has been minimized.

@svbergerem

svbergerem Dec 14, 2014

Member

The title of this PR is "[WIP] ..." ;) That is a leftover of some testing.

This comment has been minimized.

@jhass

jhass Dec 14, 2014

Member

Alright, I was never here then! walks away

@@ -48,6 +48,7 @@ en:
remove_contact: "Remove contact"
error_add: "Couldn't add <%= name %> to the aspect :("
error_remove: "Couldn't remove <%= name %> from the aspect :("
no_contacts: "You don't have any contacts here yet."

This comment has been minimized.

@jhass

jhass Dec 14, 2014

Member

That means I have them somewhere else? ;)

@svbergerem svbergerem force-pushed the svbergerem:contacts-backbonejs branch 5 times, most recently from ef16a7d to df59c51 Dec 14, 2014

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Dec 18, 2014

I implemented infinite scrolling. I still need to fix the contact search (doesn't work with infinite scrolling) and work on the tests.

@svbergerem svbergerem force-pushed the svbergerem:contacts-backbonejs branch from df59c51 to a5aed00 Dec 18, 2014

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Dec 19, 2014

Now this should be fully functional. Only the tests are missing.

@svbergerem svbergerem force-pushed the svbergerem:contacts-backbonejs branch 4 times, most recently from d198978 to 25aa035 Dec 20, 2014

@svbergerem svbergerem changed the title [WIP] Port contacts page to backbonejs Port contacts page to backbonejs Dec 20, 2014

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Dec 20, 2014

Done. Review & merge would be appreciated. :)

@svbergerem svbergerem force-pushed the svbergerem:contacts-backbonejs branch from 25aa035 to 1362f8b Dec 21, 2014

@jhass

This comment has been minimized.

Copy link
Member

jhass commented Dec 21, 2014

The only remarks I'd have a more enhancements upon this, which probably are more things for further follow up PRs.

  • Switching between My Contacts and an aspect as well as between two aspects and ideally all of the menu points shouldn't reload the page, it should filter and rerender the contacts clientside.
  • The quickfilter should be on all pages.
@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Dec 21, 2014

Before we activate the quickfilter on all pages we might want to port the aspect membership dropdown to render it on the client side. (Because I rerender the contacts when the filter is active and that would cause a lot of requests to the server for the dropdowns) Apart from that I agree that both points would be great improvements for follow up PRs.

Steffen van Bergerem added some commits Dec 11, 2014

Steffen van Bergerem
Fix jasmine specs
toBeTruethy and toBeFalsy don't test anything
use toBeTruthy() and toBeFalsy() instead

@svbergerem svbergerem force-pushed the svbergerem:contacts-backbonejs branch from 1362f8b to 99fd571 Jan 4, 2015

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Jan 4, 2015

I fixed some jasmine specs. (They didn't test anything) The specs for the contacts view were broken before and I just moved to broken specs to a new file with my first commit. The specs for the notifications view were also affected. This is why I did those changes in a new commit.

As soon as the Travis build succeeds this should be ready to merge.

@jhass jhass added this to the next-major milestone Jan 6, 2015

@jhass

This comment has been minimized.

Copy link
Member

jhass commented Jan 6, 2015

Thank you!

@jhass jhass merged commit 99fd571 into diaspora:develop Jan 6, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

jhass added a commit that referenced this pull request Jan 6, 2015

Merge pull request #5473 from svbergerem/contacts-backbonejs
Port contacts page to backbonejs
@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Jan 6, 2015

Awesome, thanks Steffen!

@svbergerem svbergerem deleted the svbergerem:contacts-backbonejs branch Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment