Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved #5482 #5489

Merged
merged 1 commit into from Jan 17, 2015

Conversation

@collimarco
Copy link
Contributor

commented Dec 20, 2014

No description provided.

@jhass

This comment has been minimized.

Copy link
Member

commented Dec 20, 2014

@jaywink can you take a look at this? I think you're more into the mobile JS stuff atm :)

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2014

I'll have a look tomorrow. @collimarco I've been trying to fix the mobile JS recently also in pull #5470 - but it needs some work still. Not sure if we're dealing with the same issue here - I'm willing to bet we are since there are many horrible crashes in the current JS code in mobile..

@jaywink jaywink self-assigned this Dec 21, 2014

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2015

Yeah confirmed this works (tested with Italic) and is relevant after (or before) #5470 - even though they overlap slightly, the edits are in the same direction :)

Let's see if travis is happy with the one last build job and then can merge..

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2015

Merging, thanks! Changelog missing, I'll add it afterwards

jaywink added a commit that referenced this pull request Jan 17, 2015

@jaywink jaywink merged commit 5c810a8 into diaspora:develop Jan 17, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2015

Btw, generic comment, please make commit message more descriptive in future, thanks :)

@jaywink jaywink added this to the next-major milestone Jan 17, 2015

jaywink added a commit that referenced this pull request Jan 17, 2015
Faldrian added a commit to Faldrian/diaspora that referenced this pull request Feb 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.