Remove limited content from email notifications #5494
Conversation
I'll look at them now. |
|
In terms of the English, they read fine, except for In terms of style/content, I think 'for you' reads better than 'to check out' (which is a bit functional); however, the private message/comment will probably not always be for you (rather than someone else), so it's not exactly appropriate here. In fact, 'for you to check out' reads better, and doesn't imply that the message/comment is necessarily for you. What do others think? Any better ideas? One other thing, is So I'd suggest: I can't comment on your code, I'm afraid, but thanks for doing this; and I hope my comments on the English are helpful. |
|
Thanks, Goobertron. Let's wait for a couple of comment more to decide about those messages. |
| @@ -15,6 +17,10 @@ def post_message(post, opts={}) | |||
| # @param opts [Hash] Optional hash. Accepts :length parameters. | |||
| # @return [String] The truncated and formatted comment. | |||
| def comment_message(comment, opts={}) | |||
| comment.message.plain_text_without_markdown truncate: opts.fetch(:length, 600) | |||
| if !comment.post.public? | |||
margori
force-pushed
the
4266-remove-content-from-email-notifications
branch
from
e9cb74f
to
c808a4d
Compare
margori
force-pushed
the
4266-remove-content-from-email-notifications
branch
from
c808a4d
to
fe60528
Compare
|
@goobertron Your suggestion included. @jhass Requested swap made. |
…notifications Remove limited content from email notifications
|
Awesome, thank you! |
|
Thanks! I'll rebase #4830 tonight, it should be ready to be merged soon. |
|
Welcome, boys and girls. This is a real pleasure. |
|
Thanks from me too. It's great to have you as part of the team, and I hope you continue coding for Diaspora! |
This is my solution to pull request #4508 that solves issue #4342 and #4266
I have doubts in messages 'notifier.a_private_message' and 'notifier.a_limited_post_comment' due to I'm not a native English speaker.
I also updated 'spec/mailers/notifier_spec.rb' file 'cause now if post is public or not changes email text, but I don't know if this file requires new tests for private mails. What do you think?