Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove limited content from email notifications #5494
I have doubts in messages 'notifier.a_private_message' and 'notifier.a_limited_post_comment' due to I'm not a native English speaker.
I also updated 'spec/mailers/notifier_spec.rb' file 'cause now if post is public or not changes email text, but I don't know if this file requires new tests for private mails. What do you think?
In terms of the English, they read fine, except for
In terms of style/content, I think 'for you' reads better than 'to check out' (which is a bit functional); however, the private message/comment will probably not always be for you (rather than someone else), so it's not exactly appropriate here. In fact, 'for you to check out' reads better, and doesn't imply that the message/comment is necessarily for you. What do others think? Any better ideas?
One other thing, is
So I'd suggest:
I can't comment on your code, I'm afraid, but thanks for doing this; and I hope my comments on the English are helpful.