Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS vendor prefixes and switch to autoprefixer #5532

Merged
merged 2 commits into from Jan 9, 2015

Conversation

@dimaursu
Copy link
Contributor

commented Jan 7, 2015

In some cases the prefixes were really old (border-radius, opacity).
Now you only have to write standard compliant CSS, and the prefixes for latest 2 versions will be added automatically.

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 7, 2015

Hm, @include comes form scss. If this includes too old stuff, maybe we can do something about it there? Is it up to date ? Can't we configure what it includes?

@dimaursu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2015

@include is for bringing in mixin functionality. Mostly from _mixins.css.scss. I deleted the ones dealing with opacity, border-shadow, and border-radius; The rest of them are useful for maintaining a consistent style, and to write shorter code. I think the ones left are reasonable.

Gemfile Outdated
@@ -54,6 +54,7 @@ gem 'rack-cors', '0.2.9', :require => 'rack/cors'
gem 'bootstrap-sass', '2.3.2.2'
gem 'compass-rails', '2.0.0'
gem 'sass-rails', '4.0.4'
gem 'autoprefixer-rails'

This comment has been minimized.

Copy link
@jhass

jhass Jan 7, 2015

Member

Please add a , '4.0.2.1'

@dimaursu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2015

I'm not sure why Travis is failing. On my computer, the hovercard shows up just fine.

@jhass

This comment has been minimized.

Copy link
Member

commented Jan 8, 2015

@dimaursu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2015

Yey! Nailed it. I grepped back and forth this time, to make sure I don't miss something :)

@ghost ghost referenced this pull request Jan 9, 2015
4 of 4 tasks complete

@dimaursu dimaursu force-pushed the dimaursu:autoprefixer branch from 7de0236 to 3e1b944 Jan 9, 2015

@jhass jhass added this to the next-major milestone Jan 9, 2015

@jhass jhass merged commit 3e1b944 into diaspora:develop Jan 9, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
jhass added a commit that referenced this pull request Jan 9, 2015
Merge pull request #5532 from dimaursu/autoprefixer
Remove CSS vendor prefixes and switch to autoprefixer
@jhass

This comment has been minimized.

Copy link
Member

commented Jan 9, 2015

Thanks!

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Jan 9, 2015

Knew it :P first change: the buttons don't have a gradient anymore:
capture du 2015-01-09 14 49 45

This also impacts the "sign in" button for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.