Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad email formatting #5578

Merged
merged 1 commit into from Jan 20, 2015

Conversation

@gdpelican
Copy link
Contributor

commented Jan 20, 2015

For #5567

Here's a sample updated email:
----==_mimepart_54bdd0e23b7cb_2012770981868097
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Hello James,

Your data has been processed and is ready for download by following this link.

Cheers,

The diaspora* email robot!

----==_mimepart_54bdd0e23b7cb_2012770981868097--

@gdpelican

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2015

This link assumes the user is logged in to access that link... not sure how valid an assumption that is. Otherwise I can try to put the actual link to the file to download in there.

@goobertron

This comment has been minimized.

Copy link

commented Jan 20, 2015

Making sure that the person who receives this email is able to log into the account concerned is not, in my opinion, a bad safety net, so I think it's good to make sure that the person trying to download these data is logged in (or can log in). I think they will get redirected automatically to the pod's sign-in page if they're not logged in when clicking the link in the email, and if so that would be fine.

@jhass jhass added this to the next-major milestone Jan 20, 2015

jhass added a commit that referenced this pull request Jan 20, 2015

@jhass jhass merged commit 3674a5a into diaspora:develop Jan 20, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jhass

This comment has been minimized.

Copy link
Member

commented Jan 20, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.