Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the header problem rendering statistics page #5587

Merged
merged 1 commit into from Jan 25, 2015

Conversation

@ghost
Copy link

commented Jan 25, 2015

Related to this comment

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2015

Great, this fixes that issue. BUT, not sure if this was the case before, but the header is not rendering when logged out.

selection_048

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2015

Yes it was visible before, I had the old test tab open :)

selection_049

After refreshing it, header disappeared.

@jaywink jaywink added this to the next-major milestone Jan 25, 2015

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2015

Doesn't works with mobile.

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 25, 2015

Should be better now.
When logged in :

screen shot 2015-01-25 at 13 27 17

When logged out :

screen shot 2015-01-25 at 13 28 07

Mobile view when logged in :

screen shot 2015-01-25 at 13 29 47

Mobile view when logged out :

screen shot 2015-01-25 at 13 29 03

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 25, 2015

Mobile view is ugly as boostrap isn't injected.
@SansPseudoFix : Up to you to write some CSS now :p

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2015

Travis one build failed due to flaky not related test, so merging. Thanks for fixing this so fast!

jaywink added a commit that referenced this pull request Jan 25, 2015
Merge pull request #5587 from AugierLe42e/fix-statistics-design
Fixes the header problem rendering statistics page

@jaywink jaywink merged commit ccd7561 into diaspora:develop Jan 25, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2015

Up to you to write some CSS now :p

LOL, missed this commit. But then, that beautification can be done separately - now it at least works :) IMHO the mobile page looks ok anyway even if the styling is different.

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 25, 2015

@jaywink : You're welcome, this was my fault. I didn't do the proper tests ;)

@ghost ghost deleted the fix-statistics-design branch Feb 14, 2015

@ghost ghost restored the fix-statistics-design branch Mar 11, 2015

@ghost ghost deleted the fix-statistics-design branch Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.