Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monthly and halfyear active users count #5590

Merged

Conversation

@Flaburgan
Copy link
Member

commented Jan 26, 2015

Fix regression introduced in #5464 or #5587, see #5589

@Flaburgan

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2015

I worry because this breaking change doesn't appear in the git diff of the 2 pull requests. That means that other changes like that could have been merged.

Why don't we have tests on that btw, perfect time to write some @AugierLe42e @SansPseudoFix

@jaywink

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2015

This is the commit that broke things, little copy paste accident which no one noticed :) dc44485

We have a test for the statistics page, but not for the scope which collects the user counts in the model. Not quite sure how efficient adding tests to those would be to prevent errors like this..

Anyway, thanks @Flaburgan - merging!

jaywink added a commit that referenced this pull request Jan 26, 2015
Merge pull request #5590 from Flaburgan/fix-monthly-halfyear-active-u…
…sers-count

Fix monthly and halfyear active users count

@jaywink jaywink merged commit 9280801 into diaspora:develop Jan 26, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@jaywink jaywink added this to the next-major milestone Jan 26, 2015

@Flaburgan Flaburgan deleted the Flaburgan:fix-monthly-halfyear-active-users-count branch Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.