Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix available services not correctly displayed #5595

Merged
merged 1 commit into from Jan 26, 2015

Conversation

@ghost
Copy link

commented Jan 26, 2015

This should fix #5589

@jhass

This comment has been minimized.

Copy link
Member

commented Jan 26, 2015

service is guaranteed to be a symbol, since that array is actually a hardcoded constant. Therefore I'd prefer the helpers to be updated to expect a symbol instead of a string.

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 26, 2015

Like this ?

@jhass jhass added this to the next-major milestone Jan 26, 2015

jhass added a commit that referenced this pull request Jan 26, 2015
Merge pull request #5595 from AugierLe42e/statistics-page-fix
Fix available services not correctly displayed

@jhass jhass merged commit aaadf29 into diaspora:develop Jan 26, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jhass

This comment has been minimized.

Copy link
Member

commented Jan 26, 2015

Yup, thanks!

Btw. your current commit author email is not associated to your github account ;)

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 27, 2015

This is because I don't want it to be displayed publicly on github.

@ghost ghost deleted the statistics-page-fix branch Feb 14, 2015

@ghost ghost restored the statistics-page-fix branch Mar 11, 2015

@ghost ghost deleted the statistics-page-fix branch Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.