Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts for reshare, expand Post and open first link in a post #5602

Merged
merged 1 commit into from Feb 7, 2015

Conversation

@Faldrian
Copy link
Contributor

commented Jan 28, 2015

This PR will add keyboard shortcuts for:

  • r - reshare
  • m - expand post (collapsed posts)
  • o - open first link in the selected post

The loomio discussion said that we should not use direct key strokes ... but I think the way to go would be to have a user option to enable / configure shortcuts / disable keyboard navigation. This could be done in a separate issue, the implementation in this PR is following existing features.

@Faldrian Faldrian force-pushed the Faldrian:more-shortcuts branch from 4e19f93 to 099974d Jan 28, 2015

@Faldrian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2015

Any comments, problems, time to review and merge? :)

@svbergerem

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Codewise this looks good to me but I haven't tried it on my dev pod yet.

Does anyone have a problem with the proposed shortcuts? ( @jhass As far as I remember you thought that r should reload the stream.)

@Faldrian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2015

Does anyone have a problem with the proposed shortcuts? ( @jhass As far as I remember you thought that r should reload the stream.)

F5 and Ctrl+r already reload "everything" ... reloading only the stream would be a nice feature, Twitter has it on "." which is at first a bit odd, but when you think of navigating with j/k the "." key is more reachable than r. I would prefer these direct shortcut keys (reshare, more, like, open) for the actions regarding to posts and the other not-so-direct keys for things where you maybe should know what you are doing or what you want to archieve. ;)

@svbergerem

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

@Faldrian Sure, I agree. I'd just like to check if anyone has any objections because I don't want to merge a (possibly) controversial PR. If everyone is happy with the proposed shortcuts I will test the code on my dev pod and merge it.

@Faldrian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2015

@svbergerem Of couse. ^^ I just wanted to bring some arguments to explain my decision to use these keys. :) Just in case or for better understanding here. Of course this should only merged if there are no objections.

@jhass

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

I guess it'll be controversial no matter how we map them, so I'd say we'll just try it out ;)

@svbergerem svbergerem merged commit 099974d into diaspora:develop Feb 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

svbergerem pushed a commit that referenced this pull request Feb 7, 2015

Steffen van Bergerem
Merge pull request #5602 from Faldrian/more-shortcuts
Add shortcuts for reshare, expand Post and open first link in a post

Conflicts:
	config/locales/diaspora/en.yml

@svbergerem svbergerem added this to the next-major milestone Feb 7, 2015

@svbergerem

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Thank you!

@Faldrian Faldrian deleted the Faldrian:more-shortcuts branch Aug 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.