Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collation and config check #5624

Merged
merged 1 commit into from Feb 7, 2015

Conversation

@dimaursu
Copy link
Contributor

commented Feb 5, 2015

This should take care of #5616 and a bunch of other complaints from our podmins.

def check_config(encoding, collation)
connection_config = ActiveRecord::Base.connection_config
fail "Database encoding is not #{encoding}!" if connection_config[:encoding] != encoding
fail "Database collation is not #{collation}!" if connection_config[:collation] != collation

This comment has been minimized.

Copy link
@jhass

jhass Feb 5, 2015

Member

fail is used nowhere in our codebase, please use raise.

This comment has been minimized.

Copy link
@dimaursu

dimaursu Feb 5, 2015

Author Contributor

we should start recommend using it :-)

This comment has been minimized.

Copy link
@jhass

jhass Feb 5, 2015

Member

But keep consistency for now.

@dimaursu dimaursu force-pushed the dimaursu:emoji branch from abdb3d5 to b94dbcf Feb 5, 2015

@dimaursu dimaursu force-pushed the dimaursu:emoji branch from b94dbcf to 0829e6f Feb 5, 2015

@rivendale2010

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2015

randomtemp

Yay! :)

@jhass jhass merged commit 0829e6f into diaspora:develop Feb 7, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

jhass added a commit that referenced this pull request Feb 7, 2015

Merge pull request #5624 from dimaursu/emoji
Add collation and config check
@jhass

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Let's try it.

@jhass jhass added this to the next-major milestone Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.