Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove photo export from settings #5634

Merged
merged 1 commit into from Feb 7, 2015

Conversation

@svbergerem
Copy link
Member

commented Feb 7, 2015

It is not working so the link on the settings page is useless. This PR also removes some unused strings that are related to photo/profile export from the locales.

Steffen van Bergerem
@goobertron

This comment has been minimized.

Copy link

commented Feb 7, 2015

Good idea. Is it worth trying to work on this? I'm wondering how useful a photo export will be, as they will be photos the user uploaded from their computer in the first place. I suppose it will be needed as part of an integrated seed migration tool, eventually.

@jhass jhass added this to the next-major milestone Feb 7, 2015

jhass added a commit that referenced this pull request Feb 7, 2015

Merge pull request #5634 from svbergerem/remove-photo-export
Remove photo export from settings

@jhass jhass merged commit 604d2b7 into diaspora:develop Feb 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jhass

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Thanks!

@svbergerem svbergerem deleted the svbergerem:remove-photo-export branch Feb 7, 2015

@margori

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2015

:-( I was going to implement this feature, fix bug #1802

I see strange that this PR was merged without discussion, as @goobertron suggested, but whatever...

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2015

@margori I removed the button because it only said "Photo exporting currently unavailable". You can still fix the photo export and add the button once photo export is working again.

@margori

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2015

you call, you get it. PR #5685 using zip files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.