Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files, fix syntax in jasmine tests #5635

Merged
merged 1 commit into from Feb 7, 2015

Conversation

@svbergerem
Copy link
Member

commented Feb 7, 2015

I removed some files that looked like they were no longer used.

While doing that I found out that some of the jasmine tests for the publisher were only succeeding when infinitescroll has been called before in app/assets/javascripts/inbox.js on an not existing element. I also found two other tests that were only "succeeding" because of syntax errors in the tests.

@jhass jhass added this to the next-major milestone Feb 7, 2015

jhass added a commit that referenced this pull request Feb 7, 2015

Merge pull request #5635 from svbergerem/remove-unused-files
Remove unused files, fix syntax in jasmine tests

@jhass jhass merged commit 3114b04 into diaspora:develop Feb 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jhass

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Thanks!

@svbergerem svbergerem deleted the svbergerem:remove-unused-files branch Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.