Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
5604 better avatar error handling #5638
This is a fix for #5604.
The solution was already in the code, but at the wrong place. When the code was executed at it's original position, the views were not yet rendered - so there were no elements to attach event handlers to.
I'm not quite happy with adding such a minor code-fixing-thing to THE MAIN VIEW-RENDER method... if you know what I mean
Another solution could be to add the line
IMHO this fix in the main renderer is well justified - we use avatars throughout the site and thus it is actually a good place to put the fix imho. At least for now since we're dealing with regression which has to be fixed for 0.5 to go out.